README.md - Issue 29720661: Issue 6391 - Allow running the browser unit tests with Firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29720661: Issue 6391 - Allow running the browser unit tests with Firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Review comments addressed. Created May 18, 2018, 12:02 a.m.

Right Patch Set: Update Firefox version in README Created Aug. 3, 2018, 4:15 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Adblock Plus core	1 Adblock Plus core

2 =================	2 =================

3	3

4 This repository contains the generic Adblock Plus code that's shared between	4 This repository contains the generic Adblock Plus code that's shared between

5 platforms. This repository is not designed to be used directly, but instead to	5 platforms. This repository is not designed to be used directly, but instead to

6 serve as a dependency for `adblockplus`, `adblockpluschrome` and	6 serve as a dependency for `adblockplus`, `adblockpluschrome` and

7 `libadblockplus`.	7 `libadblockplus`.

8	8

9 Running the unit tests	9 Running the unit tests

10 ----------------------	10 ----------------------

(...skipping 12 matching lines...) Expand all Loading...
23 ### Running specific tests	23 ### Running specific tests

24	24

25 You can specify specific test files or directories on the command line, e.g.:	25 You can specify specific test files or directories on the command line, e.g.:

26 `npm test test/synchronizer.js test/browser/elemHideEmulation.js`.	26 `npm test test/synchronizer.js test/browser/elemHideEmulation.js`.

27	27

28 ### Running the browser tests in a real browser	28 ### Running the browser tests in a real browser

29	29

30 The tests under `test/browser` require a browser environment. `npm test` will	30 The tests under `test/browser` require a browser environment. `npm test` will

31 run these in a headless browser, with each module being loaded in a new frame.	31 run these in a headless browser, with each module being loaded in a new frame.

32	32

33 The default is to run in both Chromium and Firefox. You can select which	33 The default is to run in both Chromium (using the remote interface)

34 runners to use by setting the BROWSER_TEST_RUNNERS environment. Possible	34 and Firefox. You can select which runners to use by setting the

35 runners (separated by a ',') are, the default being "chromium,firefox":	35 BROWSER_TEST_RUNNERS environment, the default is

	36 "chromium_remote,firefox". Possible values (separated by a ',') are:

36	37

37 - "chromium_remote": Chromium 60 (using the remote interface)	38 - "chromium_remote": Chromium 60 (using the remote interface)

38 - "chromium": Chrome 63 (using WebDriver)	39 - "chromium": Chrome 63 (using WebDriver)

39 - "firefox": Firefox 60	40 - "firefox": Firefox 56 (using WebDriver)

40	41

41 You can't set a specific version of the browser at runtime.	42 You can not set a specific version of the browser at runtime.

42	43

43 Linting	44 Linting

44 -------	45 -------

45	46

46 You can lint the code using [ESLint](http://eslint.org).	47 You can lint the code using [ESLint](http://eslint.org).

47	48

48 eslint *.js chrome lib test	49 eslint *.js chrome lib test

49	50

50 You will need to set up ESLint and our configuration first, see	51 You will need to set up ESLint and our configuration first, see

51 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)	52 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

52 for more information.	53 for more information.

LEFT	RIGHT