Delta Between Two Patch Sets: README.md
Issue 29720661:
Issue 6391 - Allow running the browser unit tests with Firefox (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Revert to default to the chrome remote interface (instead of webdriver)
Created July 31, 2018, 4:56 p.m.
Right Patch Set: Update Firefox version in README
Created Aug. 3, 2018, 4:15 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« .hgignore ('k')
|
package.json » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 Adblock Plus core | 1 Adblock Plus core |
| 2 ================= | 2 ================= |
| 3 | 3 |
| 4 This repository contains the generic Adblock Plus code that's shared between | 4 This repository contains the generic Adblock Plus code that's shared between |
| 5 platforms. This repository is not designed to be used directly, but instead to | 5 platforms. This repository is not designed to be used directly, but instead to |
| 6 serve as a dependency for `adblockplus`, `adblockpluschrome` and | 6 serve as a dependency for `adblockplus`, `adblockpluschrome` and |
| 7 `libadblockplus`. | 7 `libadblockplus`. |
| 8 | 8 |
| 9 Running the unit tests | 9 Running the unit tests |
| 10 ---------------------- | 10 ---------------------- |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 The tests under `test/browser` require a browser environment. `npm test` will | 30 The tests under `test/browser` require a browser environment. `npm test` will |
| 31 run these in a headless browser, with each module being loaded in a new frame. | 31 run these in a headless browser, with each module being loaded in a new frame. |
| 32 | 32 |
| 33 The default is to run in both Chromium (using the remote interface) | 33 The default is to run in both Chromium (using the remote interface) |
| 34 and Firefox. You can select which runners to use by setting the | 34 and Firefox. You can select which runners to use by setting the |
| 35 BROWSER_TEST_RUNNERS environment, the default is | 35 BROWSER_TEST_RUNNERS environment, the default is |
| 36 "chromium_remote,firefox". Possible values (separated by a ',') are: | 36 "chromium_remote,firefox". Possible values (separated by a ',') are: |
| 37 | 37 |
| 38 - "chromium_remote": Chromium 60 (using the remote interface) | 38 - "chromium_remote": Chromium 60 (using the remote interface) |
| 39 - "chromium": Chrome 63 (using WebDriver) | 39 - "chromium": Chrome 63 (using WebDriver) |
| 40 - "firefox": Firefox 60 | 40 - "firefox": Firefox 56 (using WebDriver) |
|
kzar
2018/08/03 15:22:49
Nit: Mind specifying that the Firefox tests run wi
hub
2018/08/03 16:13:53
Done.
| |
| 41 | 41 |
| 42 You can not set a specific version of the browser at runtime. | 42 You can not set a specific version of the browser at runtime. |
| 43 | 43 |
| 44 Linting | 44 Linting |
| 45 ------- | 45 ------- |
| 46 | 46 |
| 47 You can lint the code using [ESLint](http://eslint.org). | 47 You can lint the code using [ESLint](http://eslint.org). |
| 48 | 48 |
| 49 eslint *.js chrome lib test | 49 eslint *.js chrome lib test |
| 50 | 50 |
| 51 You will need to set up ESLint and our configuration first, see | 51 You will need to set up ESLint and our configuration first, see |
| 52 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | 52 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) |
| 53 for more information. | 53 for more information. |
| LEFT | RIGHT |
« .hgignore ('k')
|
package.json » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
