Issue 6532 - Removes required subscription title input field

js/desktop-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 719 matching lines @@
         url: findParentData(element, "access", false)
       });
       break;
     case "validate-import-subscription":
       let form = findParentData(element, "validation", true);
       if (!form)
         return;
 
       if (form.checkValidity())
       {
-        addEnableSubscription(E("import-list-url").value,
-          E("import-list-title").value);
+        addEnableSubscription(E("import-list-url").value);
         form.reset();
         closeDialog();
       }
       else
       {
         form.querySelector(":invalid").focus();
       }
       break;
   }
 }
@@ skipping 470 matching lines @@
     sendMessageHandleErrors({
       type: "filters.add",
       text: "@@||" + host.toLowerCase() + "^$document"
     });
   }
 
   domain.value = "";
   E("whitelisting-add-button").disabled = true;
 }
 
-function addEnableSubscription(url, title, homepage)

[Thomas Greiner, 2018/04/06 13:57:27]

Please don't change the signature of this function. It's being used by other
parts of the code where we do pass a title. Therefore those parts would break if
we remove this argument.

[Jon Sonesen, 2018/04/09 04:12:01]

Acknowledged. I did dig around the code in this file I could not find anywhere
else that uses a title, additionally I made sure to test the addition of new
subscriptions and didn't see console errors. Also, the default titles appeared
without error, perhaps I am missing something?

[Thomas Greiner, 2018/04/09 11:26:59]

It's called in line 584 as `addEnableSubscription(url, title)` where it's used
to add a filter list via an abp-subscribe link because those links usually also
contain the filter list title.

So the only argument that seems to be redundant here is `homepage`.

[Thomas Greiner, 2018/04/27 09:48:46]

No need to remove the "homepage" argument as part of this review.

+function addEnableSubscription(url, homepage)
 {
   let messageType = null;
   let knownSubscription = subscriptionsMap[url];
   if (knownSubscription && knownSubscription.disabled == true)
     messageType = "subscriptions.toggle";
   else
     messageType = "subscriptions.add";
 
   let message = {
     type: messageType,
     url
   };
-  if (title)
-    message.title = title;
   if (homepage)
     message.homepage = homepage;
 
   browser.runtime.sendMessage(message);
 }
 
 function onFilterMessage(action, filter)
 {
   switch (action)
   {
@@ skipping 243 matching lines @@
            "ui_warn_tracking"]
 });
 port.postMessage({
   type: "subscriptions.listen",
   filter: ["added", "disabled", "homepage", "lastDownload", "removed",
            "title", "downloadStatus", "downloading"]
 });
 
 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 window.addEventListener("hashchange", onHashChange, false);