desktop-options.html - Issue 29736629: Issue 6532 - Removes required subscription title input field

Delta Between Two Patch Sets: desktop-options.html

Issue 29736629: Issue 6532 - Removes required subscription title input field (Closed) Base URL: https://hg.adblockplus.org/adblockplusui

Left Patch Set: Address PS1 comments Created April 3, 2018, 9:47 p.m.

Right Patch Set: Address PS2 comments Created April 9, 2018, 8:46 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 - This file is part of Adblock Plus <https://adblockplus.org/>,	3 - This file is part of Adblock Plus <https://adblockplus.org/>,

4 - Copyright (C) 2006-present eyeo GmbH	4 - Copyright (C) 2006-present eyeo GmbH

5 -	5 -

6 - Adblock Plus is free software: you can redistribute it and/or modify	6 - Adblock Plus is free software: you can redistribute it and/or modify

7 - it under the terms of the GNU General Public License version 3 as	7 - it under the terms of the GNU General Public License version 3 as

8 - published by the Free Software Foundation.	8 - published by the Free Software Foundation.

9 -	9 -

10 - Adblock Plus is distributed in the hope that it will be useful,	10 - Adblock Plus is distributed in the hope that it will be useful,

(...skipping 381 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
392 </span>	392 </span>

393 </span>	393 </span>

394 </button>	394 </button>

395 </template>	395 </template>

396 </ul>	396 </ul>

397 </div>	397 </div>

398 <!-- Add import subscription -->	398 <!-- Add import subscription -->

399 <div id="dialog-content-import" class="dialog-content">	399 <div id="dialog-content-import" class="dialog-content">

400 <form data-validation="custom" novalidate>	400 <form data-validation="custom" novalidate>

401 <p class="floating-input">	401 <p class="floating-input">

402 <input placeholder=" " id="import-list-url" type="url" required/>	402 <input placeholder=" " id="import-list-url" class="default-focus" type="url" required/>

403 <label for="import-list-url" class="default-focus i18n_options_dia log_import_subscription_location"></label>	403 <label for="import-list-url" class="i18n_options_dialog_import_sub scription_location"></label>
Thomas Greiner 2018/04/06 13:57:26 Detail: The "default-focus" class used to be assig Detail: The "default-focus" class used to be assigned to the `<input>` element, not to the `<label>` element. While it may work as is, note that our translation resolution logic is quite hacky which means that "i18n_" classes only work when they are placed at the very beginning of the "class" attribute. Therefore please move the class to the element above. Jon Sonesen* 2018/04/09 04:12:01 Acknowledged. Show quoted text On 2018/04/06 13:57:26, Thomas Greiner wrote: > Detail: The "default-focus" class used to be assigned to the `<input>` element, > not to the `<label>` element. > > While it may work as is, note that our translation resolution logic is quite > hacky which means that "i18n_*" classes only work when they are placed at the > very beginning of the "class" attribute. > > Therefore please move the class to the element above. Acknowledged.
404 <span class="icon attention"></span>	404 <span class="icon attention"></span>

405 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span>	405 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span>

406 </p>	406 </p>

407 <p class="side-controls">	407 <p class="side-controls">

408 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button>	408 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button>

409 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button>	409 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button>

410 </p>	410 </p>

411 </form>	411 </form>

412 </div>	412 </div>

413 <!-- Add predefined subscription -->	413 <!-- Add predefined subscription -->

(...skipping 10 matching lines...) Expand all Loading...
424 </div>	424 </div>

425 <!-- Notification -->	425 <!-- Notification -->

426 <div id="notification" aria-hidden="true" aria-live="polite">	426 <div id="notification" aria-hidden="true" aria-live="polite">

427 <strong id="notification-text"></strong>	427 <strong id="notification-text"></strong>

428 <button class="icon close secondary" data-action="hide-notification">	428 <button class="icon close secondary" data-action="hide-notification">

429 <span class="i18n_options_notification_hide sr-only"></span>	429 <span class="i18n_options_notification_hide sr-only"></span>

430 </button>	430 </button>

431 </div>	431 </div>

432 </body>	432 </body>

433 </html>	433 </html>

LEFT	RIGHT