Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: desktop-options.html

Issue 29736629: Issue 6532 - Removes required subscription title input field (Closed) Base URL: https://hg.adblockplus.org/adblockplusui
Patch Set: Address PS1 comments Created April 3, 2018, 9:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | js/desktop-options.js » ('j') | js/desktop-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: desktop-options.html
===================================================================
--- a/desktop-options.html
+++ b/desktop-options.html
@@ -394,24 +394,18 @@
</button>
</template>
</ul>
</div>
<!-- Add import subscription -->
<div id="dialog-content-import" class="dialog-content">
<form data-validation="custom" novalidate>
<p class="floating-input">
- <input placeholder=" " id="import-list-title" type="text" class="default-focus" required />
- <label for="import-list-title" class="i18n_options_dialog_import_subscription_title"></label>
- <span class="icon attention"></span>
- <span class="i18n_options_dialog_import_subscription_title_error error-msg"></span>
- </p>
- <p class="floating-input">
<input placeholder=" " id="import-list-url" type="url" required/>
- <label for="import-list-url" class="i18n_options_dialog_import_subscription_location"></label>
+ <label for="import-list-url" class="default-focus i18n_options_dialog_import_subscription_location"></label>
Thomas Greiner 2018/04/06 13:57:26 Detail: The "default-focus" class used to be assig
Jon Sonesen 2018/04/09 04:12:01 Acknowledged.
<span class="icon attention"></span>
<span class="i18n_options_dialog_import_subscription_location_error error-msg"></span>
</p>
<p class="side-controls">
<button class="i18n_options_customFilter_cancel secondary" type="reset" data-action="close-dialog"></button>
<button type="button" class="i18n_options_dialog_import_title primary" data-action="validate-import-subscription"></button>
</p>
</form>
« no previous file with comments | « no previous file | js/desktop-options.js » ('j') | js/desktop-options.js » ('J')

Powered by Google App Engine
This is Rietveld