Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/whitelisting.js

Issue 29737602: Issue 4580 - Make filter/request logging use plain tabIds, prepare for multi-tab requests (Closed)
Patch Set: Created April 2, 2018, 12:27 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/stats.js ('K') | « lib/stats.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/whitelisting.js
===================================================================
--- a/lib/whitelisting.js
+++ b/lib/whitelisting.js
@@ -26,7 +26,7 @@
const {stringifyURL, getDecodedHostname,
extractHostFromFrame, isThirdParty} = require("url");
const {port} = require("messaging");
-const devtools = require("devtools");
+const {logWhitelistedDocument} = require("devtools");
const {verifySignature} = require("rsa");
let sitekeys = new ext.PageMap();
@@ -43,12 +43,8 @@
urlString, typeMask, docDomain, thirdParty, sitekey
);
- if (filter && devtools)
- {
- devtools.logWhitelistedDocument(
- page, urlString, typeMask, docDomain, filter
- );
- }
+ if (filter)
+ logWhitelistedDocument(page.id, urlString, typeMask, docDomain, filter);
return filter;
}
« lib/stats.js ('K') | « lib/stats.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld