Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: templates/manifest.json.tmpl

Issue 29743581: Issue 6552 - Support arbitrary manifest values (Closed) Base URL: https://hg.adblockplus.org/buildtools/file/a3db4a1a49e8
Patch Set: Created April 12, 2018, 1:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « packagerChrome.py ('k') | tests/expecteddata/manifest_chrome_development_build.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: templates/manifest.json.tmpl
diff --git a/templates/manifest.json.tmpl b/templates/manifest.json.tmpl
index e2cf347d08c8b8bdcbff4b73b24f3c2eed281e79..6e90641b0f86d012f881d4be43f03aa9d4e3b178 100644
--- a/templates/manifest.json.tmpl
+++ b/templates/manifest.json.tmpl
@@ -111,6 +111,14 @@
"web_accessible_resources": {{webAccessible|json}},
{%- endif %}
+ {%- if externallyConnectable %}
+ "externally_connectable": {
+ {% for key in externallyConnectable %}
+ "{{key}}": {{externallyConnectable[key]|json}}{%- if not loop.last -%},{%- endif -%}
+ {% endfor %}
+ },
+ {%- endif %}
Sebastian Noack 2018/04/12 15:10:49 I just noticed, so we still have to add each suppo
tlucas 2018/04/12 15:29:30 Uh. good catch. on it.
tlucas 2018/04/13 09:14:59 Done.
+
{%- if metadata.has_option('general', 'managedStorageSchema') %}
"storage": {
"managed_schema": {{metadata.get('general', 'managedStorageSchema')|json}}
« no previous file with comments | « packagerChrome.py ('k') | tests/expecteddata/manifest_chrome_development_build.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld