Delta Between Two Patch Sets: pages/requirements.tmpl
Issue 29749597:
Fixes #17 - Added Microsoft Edge to requirements page (Closed)
Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set:
Created April 11, 2018, 9:17 p.m.
Right Patch Set: Addressed #2
Created April 12, 2018, 3:24 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Adblock Plus system requirements | 1 title=Adblock Plus system requirements |
| 2 | 2 |
| 3 {%- macro browser_versions(browser_name, internal_name, versions) %} | 3 {%- macro browser_versions(browser_name, internal_name, versions) %} |
| 4 <h2 id="{{ internal_name }}">{{ browser_name }}</h2> | 4 <h2 id="{{ internal_name }}">{{ browser_name }}</h2> |
| 5 <ul> | 5 <ul> |
| 6 {%- set versions = versions or get_browser_versions(internal_name) %} | 6 {%- set versions = versions or get_browser_versions(internal_name) %} |
| 7 {%- if versions.previous %} | 7 {%- if versions.previous %} |
| 8 <li>{{ browser_name }} {{ versions.previous }}</li> | 8 <li>{{ browser_name }} {{ versions.previous }}</li> |
| 9 {%- endif %} | 9 {%- endif %} |
| 10 <li>{{ browser_name }} {{ versions.current }}</li> | 10 <li>{{ browser_name }} {{ versions.current }}</li> |
| (...skipping 21 matching lines...) Expand all Loading... | |
| 32 <li>Safari 7</li> | 32 <li>Safari 7</li> |
| 33 <li>Safari 8</li> | 33 <li>Safari 8</li> |
| 34 <li>Safari 9</li> | 34 <li>Safari 9</li> |
| 35 <li>Safari 10</li> | 35 <li>Safari 10</li> |
| 36 <li>Safari 11</li> | 36 <li>Safari 11</li> |
| 37 </ul> | 37 </ul> |
| 38 | 38 |
| 39 <h2 id="microsoft-edge">Microsoft Edge</h2> | 39 <h2 id="microsoft-edge">Microsoft Edge</h2> |
| 40 <ul> | 40 <ul> |
| 41 <li>{{ "Microsoft Edge released with Windows 10 Anniversary Update (EdgeHTML 1 4.14393) (legacy support)" | translate("edge-anniversary-update", "list item") } }</li> | 41 <li>{{ "Microsoft Edge released with Windows 10 Anniversary Update (EdgeHTML 1 4.14393) (legacy support)" | translate("edge-anniversary-update", "list item") } }</li> |
| 42 </li>{{ "Microsoft Edge released with Windows 10 Fall Creators Update (EdgeHTM L 16.16299)" | translate("edge-creators-update", "list-item") }}</li> | 42 <li>{{ "Microsoft Edge released with Windows 10 Fall Creators Update (EdgeHTML 16.16299)" | translate("edge-creators-update", "list item") }}</li> |
|
ire
2018/04/12 15:17:20
NIT: "list-item" vs "list item"
ire
2018/04/12 15:17:20
You used a closing instead of an opening <li> tag
| |
| 43 </ul> | 43 </ul> |
| 44 | 44 |
| 45 <h2 id="internet-explorer">Internet Explorer</h2> | 45 <h2 id="internet-explorer">Internet Explorer</h2> |
| 46 <ul> | 46 <ul> |
| 47 <li>Internet Explorer 8</li> | 47 <li>Internet Explorer 8</li> |
| 48 <li>Internet Explorer 9</li> | 48 <li>Internet Explorer 9</li> |
| 49 <li>Internet Explorer 10</li> | 49 <li>Internet Explorer 10</li> |
| 50 <li>Internet Explorer 11</li> | 50 <li>Internet Explorer 11</li> |
| 51 </ul> | 51 </ul> |
| 52 | 52 |
| 53 {{ browser_versions("Yandex.Browser", "yandex") }} | 53 {{ browser_versions("Yandex.Browser", "yandex") }} |
| 54 | 54 |
| 55 {{ browser_versions("Firefox Mobile", "fennec", firefox_versions) }} | 55 {{ browser_versions("Firefox Mobile", "fennec", firefox_versions) }} |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
