static/testcasefiles/document/stylesheet.css - Issue 29755578: Issue 2148 - Rewrite the testpages test suite

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: static/testcasefiles/document/stylesheet.css

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)

Left Patch Set: Created April 18, 2018, 11:54 a.m.

Right Patch Set: Fixed README title Created June 7, 2018, 1:58 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 #test-article {	1 #test-article {

2 » background: none;	2 background: none;
kzar 2018/04/19 13:08:23 Nit: Git warned me that you've accidentally put a Nit: Git warned me that you've accidentally put a tab character (instead of spaces) here.
3 background-color: red;	3 background-color: red;

4 }	4 }

5	5

6 .testcase-teststylesheet {	6 .testcase-teststylesheet {

7 color: white;	7 color: white;

8 background: green;	8 background: green;

9 padding: .5rem;	9 padding: .5rem;
kzar 2018/04/19 13:08:23 I noticed .testcase-scripttarget (the message on t I noticed .testcase-scripttarget (the message on the script page) doesn't get the same padding. Did you forget to add that class in here? kzar 2018/06/04 17:17:28 What about this comment? Show quoted text On 2018/04/19 13:08:23, kzar wrote: > I noticed .testcase-scripttarget (the message on the script page) doesn't get > the same padding. Did you forget to add that class in here? What about this comment? rossg 2018/06/07 10:30:23 I had addressed that by adding padding to .testcas Show quoted text On 2018/06/04 17:17:28, kzar wrote: > On 2018/04/19 13:08:23, kzar wrote: > > I noticed .testcase-scripttarget (the message on the script page) doesn't get > > the same padding. Did you forget to add that class in here? > > What about this comment? I had addressed that by adding padding to .testcase-scripttarget globally in the sites stylesheet. kzar 2018/06/07 11:43:03 Acknowledged. Show quoted text On 2018/06/07 10:30:23, rossg wrote: > On 2018/06/04 17:17:28, kzar wrote: > > On 2018/04/19 13:08:23, kzar wrote: > > > I noticed .testcase-scripttarget (the message on the script page) doesn't > get > > > the same padding. Did you forget to add that class in here? > > > > What about this comment? > > I had addressed that by adding padding to .testcase-scripttarget globally in the > sites stylesheet. Acknowledged.
10 }	10 }

11	11

12 .testcase-teststylesheet::after {	12 .testcase-teststylesheet::after {

13 background: green;	13 background: green;

14 content: "Stylesheet was loaded and applied to page.";	14 content: "Stylesheet was loaded and applied to page.";

15 }	15 }

16	16

LEFT	RIGHT