Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/exceptions/xmlhttprequest.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed more feedback. Added README. Created June 7, 2018, 10:20 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/exceptions/xmlhttprequest.tmpl
===================================================================
--- a/pages/exceptions/xmlhttprequest.tmpl
+++ b/pages/exceptions/xmlhttprequest.tmpl
@@ -1,4 +1,4 @@
-title = $xmlhttprequest Exception - ABP Test Pages
+title = $xmlhttprequest Exception
template = testcase
{% set testcase_moreinfo = [
@@ -6,12 +6,6 @@
] %}
<script>
-function pagelog(message) {
- var log = document.getElementById("testcase-ex-xmlhttprequest");
- log.innerText = log.innerText + message + "\n";
- console.log(message);
-}
-
function aborted(evt) {
pagelog("XMLHTTPRequest was aborted.");
}
@@ -39,6 +33,7 @@
<section class="site-panel">
<h2>$xmlhttprequest Exception</h2>
<p>Check that usage of the $xmlhttprequest filter option in an exception filter works as expected.</p>
+ <p>With the filter(s) displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest should not be blocked while the image should be.</p>
</section>
<section class="site-panel">
@@ -46,13 +41,13 @@
<p>The XMLHTTPRequest should not be blocked. The Image should be blocked.</p>
<div class="testcase-container">
<div class="testcase-row">
- <h3>XMLHTTPRequest</h3><div id="testcase-ex-xmlhttprequest"></div>
+ <h3>XMLHTTPRequest</h3><div id="testcase-output"></div>
</div>
<div class="testcase-row">
<h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttprequestexception/image.jpg"/>
</div>
</div>
<h3>Filters</h3>
- ||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*<br>
- @@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhttprequest
+ <pre>||testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/*</pre>
+ <pre>@@testpages.adblockplus.org/testcasefiles/xmlhttprequestexception/$xmlhttprequest</pre>
</section>
« README.md ('K') | « pages/exceptions/subdocument.tmpl ('k') | pages/filters/blocking.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld