Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/webrtc.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed more feedback. Added README. Created June 7, 2018, 10:20 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pages/filters/webrtc.tmpl
===================================================================
--- a/pages/filters/webrtc.tmpl
+++ b/pages/filters/webrtc.tmpl
@@ -1,4 +1,4 @@
-title = $webrtc - ABP Test Pages
+title = $webrtc
template = testcase
{% set testcase_moreinfo = [
@@ -10,12 +10,6 @@
// Borrowed from https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
-function pagelog(message) {
- var log = document.getElementById("testcase-fo-webrtc");
- log.innerText = log.innerText + message + "\n";
- console.log(message);
-}
-
function handleReceiveMessage(event) {
pagelog(event.data);
}
@@ -23,7 +17,7 @@
function handleLocalAddCandidateSuccess() {
pagelog("handleLocalAddCandidateSuccess()")
}
-
+
function handleRemoteAddCandidateSuccess() {
pagelog("handleRemoteAddCandidateSuccess()")
}
@@ -37,7 +31,7 @@
function handleSendChannelStatusChange(event) {
if (sendChannel) {
var state = sendChannel.readyState;
-
+
if (state === "open") {
pagelog("handleSendChannelStatusChange() open")
sendChannel.send("Test Message");
@@ -87,15 +81,17 @@
<section class="site-panel">
<h2>$webrtc</h2>
<p>Check that usage of the $webrtc filter option works as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the WebRTC connection should be blocked.</p>
+ <p>Note: This test does not work correctly yet.</p>
</section>
<section class="site-panel">
<h2>Test case</h2>
<div class="testcase-container">
<div class="testcase-row">
- <h3>WebRTC Request</h3><div id="testcase-fo-webrtc"></div>
+ <h3>WebRTC Request</h3><div id="testcase-output"></div>
</div>
</div>
<h3>Filters</h3>
- $webrtc,domain=testpages.adblockplus.org
+ <pre>$webrtc,domain=testpages.adblockplus.org</pre>
</section>
« README.md ('K') | « pages/filters/subdocument.tmpl ('k') | pages/filters/websocket.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld