Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/filters/xmlhttprequest.tmpl

Issue 29755578: Issue 2148 - Rewrite the testpages test suite (Closed)
Patch Set: Addressed more feedback. Added README. Created June 7, 2018, 10:20 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« README.md ('K') | « pages/filters/websocket.tmpl ('k') | pages/index.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/filters/xmlhttprequest.tmpl
===================================================================
--- a/pages/filters/xmlhttprequest.tmpl
+++ b/pages/filters/xmlhttprequest.tmpl
@@ -1,4 +1,4 @@
-title = $xmlhttprequest - ABP Test Pages
+title = $xmlhttprequest
template = testcase
{% set testcase_moreinfo = [
@@ -6,12 +6,6 @@
] %}
<script>
-function pagelog(message) {
- var log = document.getElementById("testcase-fo-xmlhttprequest");
- log.innerText = log.innerText + message + "\n";
- console.log(message);
-}
-
function aborted(evt) {
pagelog("XMLHTTPRequest was aborted.");
}
@@ -39,6 +33,7 @@
<section class="site-panel">
<h2>$xmlhttprequest</h2>
<p>Check that usage of the $xmlhttprequest filter option works as expected.</p>
+ <p>With the filter displayed below each test case added to ABP (or with the testcase subscription installed and active), the XMLHTTPRequest in each test case panel should be blocked but the images should not.</p>
</section>
<section class="site-panel">
@@ -46,12 +41,12 @@
<p>The XMLHTTPRequest should be blocked. The Image should not be blocked.</p>
<div class="testcase-container">
<div class="testcase-row">
- <h3>XMLHTTPRequest</h3><div id="testcase-fo-xmlhttprequest"></div>
+ <h3>XMLHTTPRequest</h3><div id="testcase-output"></div>
</div>
<div class="testcase-row">
<h3>Image</h3><img class="testcase-image" src="/testcasefiles/xmlhttprequest/image.jpg"/>
</div>
</div>
<h3>Filters</h3>
- testpages.adblockplus.org/testcasefiles/xmlhttprequest/$xmlhttprequest
+ <pre>testpages.adblockplus.org/testcasefiles/xmlhttprequest/$xmlhttprequest</pre>
</section>
« README.md ('K') | « pages/filters/websocket.tmpl ('k') | pages/index.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld