Noissue - Adapt best practices for trailing commas (buildtools)

tests/test_packagerWebExt.py

 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import difflib
 import json
 import os
 import re
 import shutil
 import zipfile
 from xml.etree import ElementTree
 from struct import unpack
 
 import pytest
 from Crypto.Signature import PKCS1_v1_5
 from Crypto.PublicKey import RSA
 from Crypto.Hash import SHA
 
 from buildtools import packager
 from buildtools.packagerChrome import defaultLocale
 from buildtools.build import process_args
 
 LOCALES_MODULE = {
     'test.Foobar': {
         'message': 'Ensuring dict-copy from modules for $domain$',
         'description': 'test description',
-        'placeholders': {'content': '$1', 'example': 'www.adblockplus.org'}
-    }
+        'placeholders': {'content': '$1', 'example': 'www.adblockplus.org'},
+    },
 }
 
 ALL_LANGUAGES = ['en_US', 'de', 'it']
 
 MESSAGES_EN_US = json.dumps({
     'name': {'message': 'Adblock Plus'},
     'name_devbuild': {'message': 'devbuild-marker'},
     'description': {
         'message': 'Adblock Plus is the most popular ad blocker ever, '
                    'and also supports websites by not blocking '
-                   'unobstrusive ads by default (configurable).'
+                   'unobstrusive ads by default (configurable).',
     },
 })
 
 
 class Content(object):
     """Base class for a unified ZipFile / Directory interface.
 
     Base class for providing a unified context manager interface for
     accessing files. This class is subclassed by ZipContent and DirContent,
     which provide the additional methods "namelist()" and "read(path)".
@@ skipping 185 matching lines @@
     files['qunit/tests/some_test.js'] = 'var passed = true;'
 
     tmpdir.mkdir('lib').join('b.js').write(files['lib/b.js'])
     ext_dir = tmpdir.mkdir('ext')
     ext_dir.join('a.js').write(files['ext/a.js'])
     ext_dir.join('c.js').write(files['ext/c.js'])
     qunit_dir = tmpdir.mkdir('qunit')
     qunit_dir.join('common.js').write(files['qunit/common.js'])
     qunit_tests_dir = qunit_dir.mkdir('tests')
     qunit_tests_dir.join('some_test.js').write(
-        files['qunit/tests/some_test.js']
+        files['qunit/tests/some_test.js'],
     )
     return files
 
 
 def comparable_json(json_data):
     """Create a nonambiguous representation of the given JSON data."""
     if isinstance(json_data, basestring):
         json_data = json.loads(json_data)
     return json.dumps(
-        json_data, sort_keys=True, indent=0
+        json_data, sort_keys=True, indent=0,
     ).split('\n')
 
 
 def comparable_xml(xml):
     """Create a nonambiguous representation of a given XML tree."""
     def strip(s):
         if s is None:
             return ''
         return s.strip()
 
@@ skipping 51 matching lines @@
     assert (os.path.join(prefix, 'devenvVersion__') in filenames) == devenv
     assert (os.path.join(prefix, 'qunit/tests.js') in filenames) == devenv
     assert (os.path.join(prefix, 'qunit/tests.js.map') in filenames) == devenv
 
     if devenv:
         quint_index = package.read(os.path.join(prefix, 'qunit/index.html'))
         assert '../ext/common.js' in quint_index
         assert '../ext/background.js' in quint_index
 
         assert set(manifest['background']['scripts']) == set(
-            scripts + ['devenvPoller__.js']
+            scripts + ['devenvPoller__.js'],
         )
     else:
         assert set(manifest['background']['scripts']) == set(scripts)
 
 
 def assert_base_files(package, platform, prefix):
     filenames = set(package.namelist())
 
     if platform == 'edge':
         assert 'AppxManifest.xml' in filenames
@@ skipping 76 matching lines @@
     manifests = {
         'gecko': [('', 'manifest', 'json')],
         'chrome': [('', 'manifest', 'json')],
         'edge': [('', 'AppxManifest', 'xml'),
                  ('Extension', 'manifest', 'json')],
     }
 
     filenames = {
         'gecko': 'adblockplusfirefox-1.2.3{}.xpi',
         'chrome': 'adblockpluschrome-1.2.3{{}}.{}'.format(
-            {True: 'crx', False: 'zip'}[release]
+            {True: 'crx', False: 'zip'}[release],
         ),
         'edge': 'adblockplusedge-1.2.3{}.appx',
     }
 
     if platform == 'edge':
         prefix = 'Extension'
     else:
         prefix = ''
 
     run_webext_build(platform, command, srcdir, keyfile=key)
@@ skipping 39 matching lines @@
             expected = os.path.join(
                 os.path.dirname(__file__),
                 'expecteddata',
                 filename.format(name, ext),
             )
 
             assert_manifest_content(
                 package.read(os.path.join(folder, '{}.{}'.format(name, ext))),
                 expected,
             )