ensure_dependencies.py - Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: ensure_dependencies.py

Issue 29756673: Noissue - Adapt best practices for trailing commas (buildtools) (Closed)

Patch Set: Created April 19, 2018, 12:58 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: ensure_dependencies.py

===================================================================

--- a/ensure_dependencies.py

+++ b/ensure_dependencies.py

@@ -41,7 +41,7 @@

'''

SKIP_DEPENDENCY_UPDATES = os.environ.get(

- 'SKIP_DEPENDENCY_UPDATES', ''

+ 'SKIP_DEPENDENCY_UPDATES', '',

).lower() not in ('', '0', 'false')

NPM_LOCKFILE = '.npm_install_lock'

@@ -147,13 +147,13 @@

# [vcs:]value

item_regexp = re.compile(

'^(?:(' + '|'.join(map(re.escape, repo_types.keys())) + '):)?'

- '(.+)$'

+ '(.+)$',

)

# [url@]rev

source_regexp = re.compile(

'^(?:(.*)@)?'

- '(.+)$'

+ '(.+)$',

)

« no previous file with comments | « chainedconfigparser.py ('k') | packagerEdge.py » ('j') | no next file with comments »