Noissue - Remove ElemHideBase.selectorDomains

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 978 matching lines @@
  *                           restricted to
  * @param {string} selector   CSS selector for the HTML elements that should be
  *                            hidden
  * @constructor
  * @augments ActiveFilter
  */
 function ElemHideBase(text, domains, selector)
 {
   ActiveFilter.call(this, text, domains || null);
 
-  if (domains)
-  {
-    this.selectorDomains = domains.replace(/,~[^,]+/g, "")
-                                  .replace(/^~[^,]+,?/, "").toLowerCase();
-  }
-
   // Braces are being escaped to prevent CSS rule injection.
   this.selector = selector.replace("{", "\\7B ").replace("}", "\\7D ");
 }
 exports.ElemHideBase = ElemHideBase;
 
 ElemHideBase.prototype = extend(ActiveFilter, {
   /**
    * @see ActiveFilter.domainSeparator
    */
   domainSeparator: ",",
 
   /**
    * @see ActiveFilter.ignoreTrailingDot
    */
   ignoreTrailingDot: false,
 
   /**
-   * Host names or domains the filter should be restricted to (can be null for
-   * no restriction)
-   * @type {?string}
-   */
-  selectorDomains: null,
-  /**
    * CSS selector for the HTML elements that should be hidden
    * @type {string}
    */
-  selector: null
+  selector: null,
+
+  /**
+   * Host names or domains the filter should be restricted to (can be null for
+   * no restriction)
+   * @type {?Array.<string>}
+   */
+  get selectorDomains()
+  {
+    let {domains} = this;
+    if (!domains)
+      return null;
+
+    return [...domains].filter(([domain, isIncluded]) => isIncluded)
+           .map(([domain]) => domain.toLowerCase());
+  }
 });
 
 /**
  * Creates an element hiding filter from a pre-parsed text representation
  *
  * @param {string} text         same as in Filter()
  * @param {string} [domains]
  *   domains part of the text representation
  * @param {string} [type]
 *    rule type, either empty or @ (exception) or ? (emulation rule)
@@ skipping 71 matching lines @@
  */
 function ElemHideEmulationFilter(text, domains, selector)
 {
   ElemHideBase.call(this, text, domains, selector);
 }
 exports.ElemHideEmulationFilter = ElemHideEmulationFilter;
 
 ElemHideEmulationFilter.prototype = extend(ElemHideBase, {
   type: "elemhideemulation"
 });