Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/address-masking.md

Issue 29790573: Fixes #6 - Extend address masking to mask other attributes (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Created May 25, 2018, 7:34 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | static/js/address-masking.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 title=Address Masking 1 title=Address Masking
2 description=Use address masking to avoid spam. 2 description=Use address masking to avoid spam.
3 3
4 # Address masking 4 # Address masking
5 5
6 Use address masking to avoid spam. 6 Use address masking to avoid spam.
7 7
8 ## Usage 8 ## Usage
9 9
10 ### Step 1: Include script on page 10 ### Step 1: Include script on page
11 11
12 Include the following script at the bottom of a page: 12 Include the following script at the bottom of a page:
13 13
14 ``` 14 ```
15 <script src="/js/address-masking.js"></script> 15 <script src="/js/address-masking.js"></script>
16 ``` 16 ```
17 17
18 ### Step 2: Base64 encode addresses 18 ### Step 2: Base64 encode addresses
19 19
20 Base64 encode sensitive `href` addresses into `data-address` attributes. 20 Base64 encode sensitive `href` addresses into `data-mask` attributes.
21 21
22 #### Markdown (before processing) 22 #### Markdown (before processing)
23 23
24 ``` 24 ```
25 [Private Email](#){: data-address="bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" } 25 [Private Email](#){: data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }'
ire 2018/05/25 07:35:05 This requires that we use a single quote for the o
juliandoucette 2018/05/25 08:50:59 You mean we can't just escape or flip the quotes t
ire 2018/05/25 09:02:10 No we can't. I will add that.
26
27 [#](#){: data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t", "textConte nt": "dXNlcm5hbWVAZXhhbXBsZS5jb20=" }'
juliandoucette 2018/05/25 08:50:59 TOL: Seems like we could make this friendlier than
ire 2018/05/25 09:02:10 Changed to "email"
26 ``` 28 ```
27 29
28 #### HTML (before processing) 30 #### HTML (before processing)
29 31
30 ``` 32 ```
31 <a data-address="bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t">Private Email</a> 33 <a data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }'>Private Email< /a>
34
35 <a data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t", "textContent": " dXNlcm5hbWVAZXhhbXBsZS5jb20=" }'>#</a>
32 ``` 36 ```
33 37
34 #### Output (after processing) 38 #### Output (after processing)
35 39
36 ``` 40 ```
37 <a href="mailto:username@example.com">Private Email</a> 41 <a href="mailto:username@example.com">Private Email</a>
42
43 <a href="mailto:username@example.com">username@example.com</a>
38 ``` 44 ```
39 45
40 ## Example 46 ## Example
41 47
42 <script src="/js/address-masking.js"></script> 48 <script src="/js/address-masking.js"></script>
43 49
44 <a data-address="bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t">Private Email</a> 50 <a data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t" }'>Private Email< /a>
51
52 <a data-mask='{ "href": "bWFpbHRvOnVzZXJuYW1lQGV4YW1wbGUuY29t", "textContent": " dXNlcm5hbWVAZXhhbXBsZS5jb20=" }'>#</a>
OLDNEW
« no previous file with comments | « no previous file | static/js/address-masking.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld