Issue 6621

lib/ioStorage.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 64 matching lines @@
    *    endings)
    * @return {Promise}
    *    Promise to be resolved or rejected once the operation is completed
    */
   writeToFile(fileName, data)
   {
     return saveFile(fileName, data);
   },
 
   /**
-   * Copies a file.
-   * @param {string} fromFile
-   *    Name of the file to be copied
-   * @param {string} toFile
-   *    Name of the file to be written, will be overwritten if exists
-   * @return {Promise}
-   *    Promise to be resolved or rejected once the operation is completed
-   */
-  copyFile(fromFile, toFile)
-  {
-    return loadFile(fromFile).then(entry => saveFile(toFile, entry.content));
-  },
-
-  /**
    * Renames a file.
    * @param {string} fromFile
    *    Name of the file to be renamed
    * @param {string} newName
    *    New file name, will be overwritten if exists
    * @return {Promise}
    *    Promise to be resolved or rejected once the operation is completed
    */
   renameFile(fromFile, newName)
   {
     return loadFile(fromFile)
       .then(entry => browser.storage.local.set({[fileToKey(newName)]: entry}))
       .then(() => this.removeFile(fromFile));
   },
 
   /**
-   * Removes a file.
-   * @param {string} fileName
-   *    Name of the file to be removed
-   * @return {Promise}
-   *    Promise to be resolved or rejected once the operation is completed
-   */
-  removeFile(fileName)
-  {
-    return browser.storage.local.remove(fileToKey(fileName));
-  },

[Sebastian Noack, 2018/06/01 19:15:46]

Well spotted! I confirmed that copyFile() and removeFile() are no longer used
(by other code). So removing them here (and not implementing them in ioIndexedDB
in the first place) is the right thing to do.

However, removeFile() is internally called by renameFile(). So you have to adapt
the code there to call browser.storage.local.remove() directly.

[piscoi.georgiana, 2018/06/05 07:15:56]

Done.

-
-  /**
    * Retrieves file metadata.
    * @param {string} fileName
    *    Name of the file to be looked up
    * @return {Promise.<StatData>}
    *    Promise to be resolved with file metadata once the operation is
    *    completed
    */
   statFile(fileName)
   {
     return loadFile(fileName).then(entry =>
     {
       return {
         exists: true,
         lastModified: entry.lastModified
       };
     }).catch(error =>
     {
       if (error.type == "NoSuchFile")
         return {exists: false};
       throw error;
     });
   }
 };