tox.ini - Issue 29805580: Issue 6728 - Remove Mercurial dependency

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tox.ini

Issue 29805580: Issue 6728 - Remove Mercurial dependency (Closed)

Patch Set: Address PS2 comments Created June 15, 2018, 5:19 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [tox]	1 [tox]

2 envlist = py27	2 envlist = py27

3 skipsdist = true	3 skipsdist = true

4	4

5 [flake8]	5 [flake8]

6 ignore = D1,C815	6 ignore = D1,C815

7 per-file-ignores =	7 per-file-ignores =

8 /cms/bin/generate_static_pages.py : A107,A301,A302,E501	8 /cms/bin/generate_static_pages.py : A107,A301,A302,E501

9 /cms/bin/test_server.py : A101,A107,A302,E501,F401	9 /cms/bin/test_server.py : A101,A107,A302,E501,F401

10 /cms/bin/translate.py : A107,A301,A302,E501,F821	10 /cms/bin/translate.py : A107,A301,A302,E501,F821

(...skipping 17 matching lines...) Expand all Loading...
28 pytest-mock	28 pytest-mock

29 wsgi_intercept	29 wsgi_intercept

30 flake8	30 flake8

31 flake8-per-file-ignores>=0.4	31 flake8-per-file-ignores>=0.4

32 flake8-docstrings	32 flake8-docstrings

33 flake8-commas	33 flake8-commas

34 pep8-naming	34 pep8-naming

35 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	35 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

36	36

37 commands =	37 commands =

38 py.test --cov-report term --cov-report html --cov=cms tests	38 py.test --cov-report term --cov-report html --cov=cms tests --basetemp=tmp
	Vasily Kuznetsov 2018/07/03 08:50:24 The --basetemp=tmp creates ./tmp directory, why do The --basetemp=tmp creates ./tmp directory, why do we need this? Also, if we do want leave this in, we should .hgignore and .gitignore it. jsonesen 2018/07/05 18:58:31 This makes debugging the test suite easier by plac Show quoted text On 2018/07/03 08:50:24, Vasily Kuznetsov wrote: > The --basetemp=tmp creates ./tmp directory, why do we need this? Also, if we do > want leave this in, we should .hgignore and .gitignore it. This makes debugging the test suite easier by placing the temporary sites made by it within the project directory rather than in the default tempfile location. At least for me I have found it makes the paths which are printed more concise. Will add to the ignore files too! Vasily Kuznetsov 2018/07/05 21:48:20 Hm, changing the temporary folder in tox.ini to ma Show quoted text On 2018/07/05 18:58:31, jsonesen wrote: > On 2018/07/03 08:50:24, Vasily Kuznetsov wrote: > > The --basetemp=tmp creates ./tmp directory, why do we need this? Also, if we > do > > want leave this in, we should .hgignore and .gitignore it. > > This makes debugging the test suite easier by placing the temporary sites made > by it within the project directory rather than in the default tempfile location. > At least for me I have found it makes the paths which are printed more concise. > Will add to the ignore files too! Hm, changing the temporary folder in tox.ini to make debugging easier is a bit questionable. Tox is more of a CI tool whereas it would be better to just manually invoke pytest for debugging (with the appropriate options). Also this change is unrelated in this review. Maybe we remove it here for now and think about it a bit?
39 flake8 cms tests runserver.py runserver.spec	39 flake8 cms tests runserver.py runserver.spec

OLD	NEW

« tests/test_page_outputs.py ('K') | « tests/test_page_outputs.py ('k') | no next file » | no next file with comments »