Issue 6745 - Prefer strict equality operator

lib/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 96 matching lines @@
 
   /**
    * Creates a Downloadable instance for a subscription.
    * @param {Subscription} subscription
    * @param {boolean} manual
    * @return {Downloadable}
    */
   _getDownloadable(subscription, manual)
   {
     let result = new Downloadable(subscription.url);
-    if (subscription.lastDownload != subscription.lastSuccess)
+    if (subscription.lastDownload !== subscription.lastSuccess)
       result.lastError = subscription.lastDownload * MILLIS_IN_SECOND;
     result.lastCheck = subscription.lastCheck * MILLIS_IN_SECOND;
     result.lastVersion = subscription.version;
     result.softExpiration = subscription.softExpiration * MILLIS_IN_SECOND;
     result.hardExpiration = subscription.expires * MILLIS_IN_SECOND;
     result.manual = manual;
     result.downloadCount = subscription.downloadCount;
     return result;
   },
 
@@ skipping 41 matching lines @@
       let match = /^\s*!\s*(\w+)\s*:\s*(.*)/.exec(lines[i]);
       if (match)
       {
         let keyword = match[1].toLowerCase();
         let value = match[2];
         if (keyword in params)
         {
           params[keyword] = value;
           remove.push(i);
         }
-        else if (keyword == "checksum")
+        else if (keyword === "checksum")
         {
           lines.splice(i--, 1);
           let checksum = Utils.generateChecksum(lines);
-          if (checksum && checksum != value.replace(/=+$/, ""))
+          if (checksum && checksum !== value.replace(/=+$/, ""))
             return errorCallback("synchronize_checksum_mismatch");
         }
       }
     }
 
     if (params.redirect)
       return redirectCallback(params.redirect);
 
     // Handle redirects
     let subscription = Subscription.fromURL(downloadable.redirectURL ||
                                             downloadable.url);
     if (downloadable.redirectURL &&
-        downloadable.redirectURL != downloadable.url)
+        downloadable.redirectURL !== downloadable.url)
     {
       let oldSubscription = Subscription.fromURL(downloadable.url);
       subscription.title = oldSubscription.title;
       subscription.disabled = oldSubscription.disabled;
       subscription.lastCheck = oldSubscription.lastCheck;
 
       let listed = FilterStorage.knownSubscriptions.has(oldSubscription.url);
       if (listed)
         FilterStorage.removeSubscription(oldSubscription);
 
@@ skipping 21 matching lines @@
       let url;
       try
       {
         url = new URL(params.homepage);
       }
       catch (e)
       {
         url = null;
       }
 
-      if (url && (url.protocol == "http:" || url.protocol == "https:"))
+      if (url && (url.protocol === "http:" || url.protocol === "https:"))
         subscription.homepage = url.href;
     }
 
     if (params.title)
     {
       subscription.title = params.title;
       subscription.fixedTitle = true;
     }
     else
       subscription.fixedTitle = false;
@@ skipping 81 matching lines @@
                                     request.channel.VALIDATE_ALWAYS;
         request.addEventListener("load", ev =>
         {
           if (onShutdown.done)
             return;
 
           if (!FilterStorage.knownSubscriptions.has(subscription.url))
             return;
 
           let match = /^(\d+)(?:\s+(\S+))?$/.exec(request.responseText);
-          if (match && match[1] == "301" &&    // Moved permanently
+          if (match && match[1] === "301" &&    // Moved permanently
               match[2] && /^https?:\/\//i.test(match[2]))
           {
             redirectCallback(match[2]);
           }
-          else if (match && match[1] == "410") // Gone
+          else if (match && match[1] === "410") // Gone
           {
             let data = "[Adblock]\n" +
               subscription.filters.map(f => f.text).join("\n");
             redirectCallback("data:text/plain," + encodeURIComponent(data));
           }
         }, false);
         request.send(null);
       }
     }
   }
 };
 Synchronizer.init();