Side by Side Diff: README.md
Issue 29807589:
Issue 6695 - Allow automatically downloading V8 (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created June 15, 2018, 1:52 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« Makefile ('K')
|
« Makefile ('k')
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 libadblockplus | 1 libadblockplus |
| 2 ============== | 2 ============== |
| 3 | 3 |
| 4 A C++ library offering the core functionality of Adblock Plus. | 4 A C++ library offering the core functionality of Adblock Plus. |
| 5 | 5 |
| 6 Getting/updating the dependencies | 6 Getting/updating the dependencies |
| 7 --------------------------------- | 7 --------------------------------- |
| 8 | 8 |
| 9 libadblockplus has dependencies that aren't part of this repository. They are | 9 libadblockplus has dependencies that aren't part of this repository. They are |
| 10 retrieved and updated during the build process, but you can also manually update | 10 retrieved and updated during the build process, but you can also manually update |
| (...skipping 30 matching lines...) Expand all Loading... | |
| 41 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip), | 41 [OS X](https://dl.google.com/android/repository/android-ndk-r16b-darwin-x86_64 .zip), |
| 42 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip). | 42 [Linux 64](https://dl.google.com/android/repository/android-ndk-r16b-linux-x86 _64.zip). |
| 43 * g++ multilib | 43 * g++ multilib |
| 44 | 44 |
| 45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/). | 45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/). |
| 46 | 46 |
| 47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`. | 47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`. |
| 48 | 48 |
| 49 ### Unix | 49 ### Unix |
| 50 | 50 |
| 51 You need V8 prior to building. Two options: | |
| 52 | |
| 53 * Use the default prebuild by invoking the make target | |
|
sergei
2018/06/18 10:16:25
Can we rephrase it to
Use the default prebuilt V8
hub
2018/06/18 12:51:10
Done.
| |
| 54 `v8prebuild`. This will download and extract the prebuild V8 for your | |
| 55 setup. The default environment will be set by the Makefile at build | |
| 56 tine. If you are cross compiling use the same options as below to | |
|
sergei
2018/06/18 10:16:25
typo: tine->time.
hub
2018/06/18 12:51:10
Done.
| |
| 57 invoke make. | |
| 58 | |
|
sergei
2018/06/18 10:16:25
I think we should add that if one needs the prebui
hub
2018/06/18 12:51:10
Done.
| |
| 59 Or | |
| 60 | |
| 51 * Prepare V8 and set environment variables LIBV8_LIB_DIR and LIBV8_INCLUDE_DIR. | 61 * Prepare V8 and set environment variables LIBV8_LIB_DIR and LIBV8_INCLUDE_DIR. |
| 52 LIBV8_INCLUDE_DIR should point to the include directory of V8, e.g. | 62 LIBV8_INCLUDE_DIR should point to the include directory of V8, e.g. |
| 53 `.../v8/include` and there should be `libv8_monolith.a` in the directory | 63 `.../v8/include` and there should be `libv8_monolith.a` in the directory |
| 54 LIBV8_LIB_DIR. | 64 LIBV8_LIB_DIR. |
| 55 | 65 |
| 66 To build: | |
| 67 | |
| 56 Using Make: | 68 Using Make: |
| 57 | 69 |
| 58 make | 70 make |
| 59 | 71 |
| 60 The default target architecture is the architecture of a host. In order to build for a different architecture pass `TARGET_ARCH` to `make`, e.g. run: | 72 The default target architecture is the architecture of a host. In order to build for a different architecture pass `TARGET_ARCH` to `make`, e.g. run: |
| 61 | 73 |
| 62 make TARGET_ARCH=ia32 | 74 make TARGET_ARCH=ia32 |
| 63 | 75 |
| 64 supported values are `ia32` and `x64`. | 76 supported values are `ia32` and `x64`. |
| 65 | |
| 66 | 77 |
| 67 To build and run the tests: | 78 To build and run the tests: |
| 68 | 79 |
| 69 make test | 80 make test |
| 70 | 81 |
| 71 Likewise, use the following with `TARGET_ARCH`: | 82 Likewise, use the following with `TARGET_ARCH`: |
| 72 | 83 |
| 73 make test TARGET_ARCH=ia32 | 84 make test TARGET_ARCH=ia32 |
| 74 | 85 |
| 75 To run specific tests, you can specify a filter: | 86 To run specific tests, you can specify a filter: |
| (...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 283 Linting | 294 Linting |
| 284 ------- | 295 ------- |
| 285 | 296 |
| 286 You can lint the code using [ESLint](http://eslint.org). | 297 You can lint the code using [ESLint](http://eslint.org). |
| 287 | 298 |
| 288 npm run eslint | 299 npm run eslint |
| 289 | 300 |
| 290 In order to set up ESLint and | 301 In order to set up ESLint and |
| 291 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. | 302 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. |
| 292 | 303 |
| OLD | NEW |
