Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/subscriptions/subscriptionParser.py

Issue 29811558: Issue 6754 - Support the "circumvention" type (Closed) Base URL: https://hg.adblockplus.org/sitescripts/
Patch Set: PEP-8 conformance Created June 20, 2018, 1:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/subscriptions/subscriptionParser.py
===================================================================
--- a/sitescripts/subscriptions/subscriptionParser.py
+++ b/sitescripts/subscriptions/subscriptionParser.py
@@ -195,17 +195,18 @@
if self._data[key] != None:
found = True
if not found:
str = ', '.join(group)
warn('None of the attributes %s present in %s' % (str, path))
if len(self.variants) == 0:
warn('No list locations given in %s' % path)
- if self.type not in ('ads', 'anti-adblock', 'other', 'malware', 'social', 'privacy'):
+ if self.type not in ('ads', 'anti-adblock', 'circumvention', 'other',
+ 'malware', 'social', 'privacy'):
warn('Unknown type given in %s' % path)
if self.digest != 'daily' and self.digest != 'weekly':
warn('Unknown digest frequency given in %s' % path)
if not self.digestDay[0:3].lower() in weekdays:
warn('Unknown digest day given in %s' % path)
self.digestDay = 'wed'
self.digestDay = weekdays[self.digestDay[0:3].lower()]
if self.recommendation is not None and self.type == 'ads' and not (self.languages and self.languages.strip()):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld