Issue 6526 - *ToV8String() return MaybeLocal<> and check Call() return value

src/FileSystemJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 169 matching lines @@
                 throw std::runtime_error("`this` pointer has to be an object");
 
               auto isolate = jsEngine->GetIsolate();
               const v8::TryCatch tryCatch(isolate);
               const auto contentEnd = content.cend();
               auto stringBegin = SkipEndOfLine(content.begin(), contentEnd);
               auto v8Context = isolate->GetCurrentContext();
               do
               {
                 auto stringEnd = AdvanceToEndOfLine(stringBegin, contentEnd);
-                auto jsLine = Utils::StringBufferToV8String(isolate, StringBuffer(stringBegin, stringEnd)).As<v8::Value>();
-                processFunc->Call(v8Context, globalContext, 1, &jsLine);
-                if (tryCatch.HasCaught())
-                  throw JsError(isolate, tryCatch.Exception(), tryCatch.Message());
+                auto jsLine = CHECKED_TO_LOCAL_WITH_TRY_CATCH(
+                  isolate,
+                  Utils::StringBufferToV8String(
+                    isolate, StringBuffer(stringBegin, stringEnd)),
+                  tryCatch).As<v8::Value>();
+
+                CHECKED_TO_LOCAL_WITH_TRY_CATCH(
+                  isolate, processFunc->Call(v8Context, globalContext, 1, &jsLine),
+                  tryCatch);
+
                 stringBegin = SkipEndOfLine(stringEnd, contentEnd);
               } while (stringBegin != contentEnd);
               jsEngine->GetJsValues(weakData->weakResolveCallback)[0].Call();
             }, [weakData](const std::string& error)
             {
               if (error.empty())
                 return;
               auto jsEngine = weakData->weakJsEngine.lock();
               if (!jsEngine)
                 return;
@@ skipping 157 matching lines @@
 JsValue& FileSystemJsObject::Setup(JsEngine& jsEngine, JsValue& obj)
 {
   obj.SetProperty("read", jsEngine.NewCallback(::ReadCallback::V8Callback));
   obj.SetProperty("readFromFile", jsEngine.NewCallback(::ReadFromFileCallback::V8Callback));
   obj.SetProperty("write", jsEngine.NewCallback(::WriteCallback));
   obj.SetProperty("move", jsEngine.NewCallback(::MoveCallback));
   obj.SetProperty("remove", jsEngine.NewCallback(::RemoveCallback));
   obj.SetProperty("stat", jsEngine.NewCallback(::StatCallback));
   return obj;
 }