.eslintrc.json - Issue 29860555: Issue 6717 - Part 2: run qunit in headless firefox

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .eslintrc.json

Issue 29860555: Issue 6717 - Part 2: run qunit in headless firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/file/3270e924ba9f

Patch Set: Fix type in README.md Created Aug. 22, 2018, 7:04 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "extends": "eslint-config-eyeo",	2 "extends": "eslint-config-eyeo",

3 "root": true,	3 "root": true,

4 "env": {	4 "env": {

5 "browser": true,	5 "browser": true,

6 "webextensions": true	6 "webextensions": true

7 },	7 },

8 "globals": {	8 "globals": {

9 "exports": true,	9 "exports": true,

10 "ext": true,	10 "ext": true,

11 "module": true,	11 "module": true,

12 "require": true	12 "require": true,

	13 "process": true,

	14 "__dirname": true
	hub 2018/08/22 16:13:56 also I'm wondering if this shouldn't go into a sub also I'm wondering if this shouldn't go into a sub configuration file in test/ like we have for adblockpluscore, since these are exception we make for the tests. Sebastian Noack 2018/08/22 18:16:38 Well, rather than whitelisting particular globals, Show quoted text On 2018/08/22 16:13:56, hub wrote: > also I'm wondering if this shouldn't go into a sub configuration file in test/ > like we have for adblockpluscore, since these are exception we make for the > tests. Well, rather than whitelisting particular globals, you should rather set eslint-env to node. Since there is only a single file you might want to do it inline just for that file, which is exactly what you did in adblockpluscore. tlucas 2018/08/22 20:24:00 As a matter of fact, this was previously only nece Show quoted text On 2018/08/22 18:16:38, Sebastian Noack wrote: > On 2018/08/22 16:13:56, hub wrote: > > also I'm wondering if this shouldn't go into a sub configuration file in test/ > > like we have for adblockpluscore, since these are exception we make for the > > tests. > > Well, rather than whitelisting particular globals, you should rather set > eslint-env to node. Since there is only a single file you might want to do it > inline just for that file, which is exactly what you did in adblockpluscore. As a matter of fact, this was previously only necessary for the test_runner.js - which is now removed. Undid these lines accordingly.
13 }	15 }

14 }	16 }

OLD	NEW

« no previous file with comments | « no previous file | README.md » ('j') | package.json » ('J')