build_requirements.txt - Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: build_requirements.txt

Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING) (Closed) Base URL: https://codereview.adblockplus.org/29860555/

Patch Set: Created Aug. 23, 2018, 7 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 cryptography==2.2.2
	Sebastian Noack 2018/08/23 23:45:06 I wonder whether we want to pin these versions. Ag I wonder whether we want to pin these versions. Against pinning exact versions arguments would be potential security fixes we will miss, additional maintainence effort if we start leveraging features of newer versions in the future, and that we don't pin exact versions for node modules either.
	2 Jinja2==2.10

OLD	NEW

« .gitlab-ci.yml ('K') | « .gitlab-ci.yml ('k') | no next file » | no next file with comments »