Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: adblockplus/metadata.gecko
Issue
29863604
:
Issue 6865 - Update ABP dependency to version 3.2 (Closed)
Patch Set: Adjusting build script and removing extension first run page
Created Jan. 8, 2019, 2:54 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Removing patch file
Patch Set 3: Adjustments based on comments
Patch Set 4: Removing allowed contexts
Patch Set 5: Adjusting build script and removing extension first run page
Patch Set 6: Adjusting code style
Right:
Patch Set 1: None
Patch Set 2: Removing patch file
Patch Set 3: Adjustments based on comments
Patch Set 4: Removing allowed contexts
Patch Set 5: Adjusting build script and removing extension first run page
Patch Set 6: Adjusting code style
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
adblockplus/build.py
adblockplus/extensionBridge.js
adblockplus/issue-6070.patch
adblockplus/issue-6108.patch
adblockplus/issue-6865.patch
adblockplus/metadata.gecko
dependencies
ensure_dependencies.py
mobile/android/base/java/org/adblockplus/browser/AbpCheckBoxPreference.java
mobile/android/base/java/org/adblockplus/browser/BrowserAppUtils.java
mobile/android/base/java/org/adblockplus/browser/ExtensionBridge.java
mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java
mobile/android/base/java/org/adblockplus/browser/SubscriptionContainer.java
mobile/android/base/java/org/adblockplus/browser/SubscriptionPreferenceCategory.java
mobile/android/base/java/org/adblockplus/browser/WhitelistedWebsitesPreferenceGroup.java
mobile/android/base/java/org/mozilla/gecko/GeckoApplication.java
mobile/android/base/moz.build
mobile/android/chrome/content/browser.js
toolkit/components/extensions/ext-c-runtime.js
toolkit/components/extensions/schemas/runtime.json
View unified diff
|
Download patch
« adblockplus/extensionBridge.js
('K') |
« adblockplus/issue-6865.patch
('k') |
dependencies »
('j') |
mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 [default]
1 [default]
2
inherit =
adblockplus
/metadata.gecko
2
inherit =
adblockpluschrome
/metadata.gecko
3
3
4
[mapping]
4
[bundles]
5
chrome/content/Api.jsm = Api.jsm
5
lib/adblockplus.js += ../extensionBridge.js
OLD
NEW
« adblockplus/extensionBridge.js
('K') |
« adblockplus/issue-6865.patch
('k') |
dependencies »
('j') |
mobile/android/base/java/org/adblockplus/browser/MoreSubscriptionsPreferenceGroup.java »
('J')
Edit Message
Issue 29863604: Issue 6865 - Update ABP dependency to version 3.2 (Closed)
Created Aug. 24, 2018, 8:38 p.m. by diegocarloslima
Modified Jan. 21, 2019, noon
Reviewers: jens, Thomas Greiner
Base URL:
Comments: 30
This is Rietveld