Issue 6890 - run npm tests in parallel (PENDING)

.gitlab-ci.yml

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 stages:
-  - test_ext
+  - prepare
+  - test
 
-qunit:gecko:
-  stage: test_ext
-  script:
+.dependencies:

[tlucas, 2018/09/03 21:35:54]

I noticed that i only cache nodejs and adblockpluschrome's dependencies, but no
python dependencies (as well as the .git folder) - hereby changed now.

IIRC, unlike npm, pip doesn't check for updates and "mkdir -p" is also a noop.

+  script: &dependencies
     - mkdir -p .git/info
     - pip install --user Jinja2 cryptography
-    - npm install
-    - npm test
+    - python ensure_dependencies.py
+    - if [ ! -d "node_modules" ]; then npm install; fi

[Sebastian Noack, 2018/09/03 21:57:47]

This could be done simpler:

  [ -d node_modules ] || npm install

[tlucas, 2018/09/04 07:19:37]

Done.

+
+prepare-dependencies:
+  stage: prepare
+  script: *dependencies
+  cache:
+    key: cache_$CI_COMMIT_SHA
+    paths:
+      - ./
+    policy: push
+
+
+.test_template: &test_template
+  stage: test
+  before_script: *dependencies
+  cache:
+    key: cache_$CI_COMMIT_SHA
+    paths:
+      - ./
+    policy: pull
+
+
+tests:gecko:
+  <<: *test_template
+  script:
+    - npm test -- -g gecko
+
+tests:chrome:
+  <<: *test_template
+  script:
+    - xvfb-run npm test -- -g chrome
+
+lint:
+  <<: *test_template
+  script:
+    - npm run lint