Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterClasses.js

Issue 29867635: Issue 6888 - Remove old abp-properties syntax conversion (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Aug. 29, 2018, 2:59 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/elemHideEmulation.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/filterClasses.js
===================================================================
--- a/test/filterClasses.js
+++ b/test/filterClasses.js
@@ -107,24 +107,16 @@
test.equal(filter.collapse, collapse);
else
test.equal(filter.collapse, undefined);
if (type == InvalidFilter)
test.ok(filter.reason, "Invalid filter " + text + " has a reason set");
})(Filter.fromText(text));
}
- // conversion from old syntax.
- withNAD(0, filter =>
- {
- test.equal(filter.text, "example.com#?#:-abp-properties(something)");
- test.ok(filter instanceof ElemHideEmulationFilter);
- test.equal(filter.type, "elemhideemulation");
- })(Filter.fromText("example.com##[-abp-properties='something']"));
-
test.done();
};
exports.testClassHierarchy = function(test)
{
let allClasses = [
Filter, InvalidFilter, CommentFilter, ActiveFilter,
RegExpFilter, BlockingFilter, WhitelistFilter, ElemHideBase,
@@ -399,23 +391,16 @@
exports.testElemHideRulesWithBraces = function(test)
{
withNAD(0, filter =>
{
test.equal(filter.type, "elemhide");
test.equal(filter.selector, "#foo\\7B color: red\\7D ");
})(Filter.fromText("###foo{color: red}"));
- // Filter conversion to the new syntax dealing with braces too.
- withNAD(0, filter =>
- {
- test.equal(filter.type, "elemhideemulation");
- test.equal(filter.selector, ":-abp-properties(/margin: [3-4]\\7B 2\\7D /)");
- })(Filter.fromText("foo.com##[-abp-properties='/margin: [3-4]{2}/']"));
-
test.done();
};
exports.testNotifications = function(test)
{
function checkNotifications(action, expected, message)
{
let result = null;
« no previous file with comments | « test/elemHideEmulation.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld