Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/filterClasses.js

Issue 29870577: Issue 6916 - Encapsulate filter subscriptions (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Add JSDoc for addSubscription and removeSubscription Created Sept. 1, 2018, 2:10 p.m.
Right Patch Set: Add subscriptionCount property Created Sept. 1, 2018, 2:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | lib/filterListener.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 throw new Error("Please define filter type in the subclass"); 67 throw new Error("Please define filter type in the subclass");
68 }, 68 },
69 69
70 /** 70 /**
71 * Yields subscriptions to which the filter belongs. 71 * Yields subscriptions to which the filter belongs.
72 * @yields {Subscription} 72 * @yields {Subscription}
73 */ 73 */
74 *subscriptions() 74 *subscriptions()
75 { 75 {
76 yield* this._subscriptions; 76 yield* this._subscriptions;
77 },
78
79 /**
80 * The number of subscriptions to which the filter belongs.
81 * @type {number}
82 */
83 get subscriptionCount()
84 {
85 return this._subscriptions.size;
77 }, 86 },
78 87
79 /** 88 /**
80 * Adds a subscription to the set of subscriptions to which the filter 89 * Adds a subscription to the set of subscriptions to which the filter
81 * belongs. 90 * belongs.
82 * @param {Subscription} subscription 91 * @param {Subscription} subscription
83 */ 92 */
84 addSubscription(subscription) 93 addSubscription(subscription)
85 { 94 {
86 this._subscriptions.add(subscription); 95 this._subscriptions.add(subscription);
(...skipping 1119 matching lines...) Expand 10 before | Expand all | Expand 10 after
1206 1215
1207 /** 1216 /**
1208 * Script that should be executed 1217 * Script that should be executed
1209 * @type {string} 1218 * @type {string}
1210 */ 1219 */
1211 get script() 1220 get script()
1212 { 1221 {
1213 return this.body; 1222 return this.body;
1214 } 1223 }
1215 }); 1224 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld