test/filterListener.js - Issue 29870577: Issue 6916 - Encapsulate filter subscriptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/filterListener.js

Issue 29870577: Issue 6916 - Encapsulate filter subscriptions (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Add JSDoc for addSubscription and removeSubscription Created Sept. 1, 2018, 2:10 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/filterListener.js

===================================================================

--- a/test/filterListener.js

+++ b/test/filterListener.js

@@ -291,28 +291,28 @@

checkKnownFilters(test, "enable blocking filters", {blacklist: [filter1.text]});

let subscription3 = Subscription.fromURL("~wl~");

subscription3.disabled = true;

checkKnownFilters(test, "disable exception rules", {blacklist: [filter1.text]});

FilterStorage.addFilter(filter2);

checkKnownFilters(test, "add @@filter2", {blacklist: [filter1.text], whitelist: [filter2.text]});

- test.equal(filter2.subscriptions.size, 1, "@@filter2.subscription.length");

- test.ok([...filter2.subscriptions][0] instanceof SpecialSubscription, "@@filter2 added to a new filter group");

- test.ok([...filter2.subscriptions][0] != subscription3, "@@filter2 filter group is not the disabled exceptions group");

+ test.equal([...filter2.subscriptions()].length, 1, "@@filter2.subscription.length");

+ test.ok([...filter2.subscriptions()][0] instanceof SpecialSubscription, "@@filter2 added to a new filter group");

+ test.ok([...filter2.subscriptions()][0] != subscription3, "@@filter2 filter group is not the disabled exceptions group");

subscription3.disabled = false;

checkKnownFilters(test, "enable exception rules", {blacklist: [filter1.text], whitelist: [filter2.text]});

FilterStorage.removeFilter(filter2);

FilterStorage.addFilter(filter2);

checkKnownFilters(test, "re-add @@filter2", {blacklist: [filter1.text], whitelist: [filter2.text]});

- test.equal(filter2.subscriptions.size, 1, "@@filter2.subscription.length");

- test.ok([...filter2.subscriptions][0] == subscription3, "@@filter2 added to the default exceptions group");

+ test.equal([...filter2.subscriptions()].length, 1, "@@filter2.subscription.length");

+ test.ok([...filter2.subscriptions()][0] == subscription3, "@@filter2 added to the default exceptions group");

let subscription4 = Subscription.fromURL("http://test/");

FilterStorage.updateSubscriptionFilters(subscription4, [filter3, filter4, filter5]);

checkKnownFilters(test, "update subscription not in the list yet", {blacklist: [filter1.text], whitelist: [filter2.text]});

FilterStorage.addSubscription(subscription4);

checkKnownFilters(test, "add subscription to the list", {blacklist: [filter1.text, filter3.text], whitelist: [filter2.text, filter4.text]});

« no previous file with comments | « lib/iniParser.js ('k') | test/filterStorage.js » ('j') | no next file with comments »