Unified Diff: abp/filters/renderer.py
Issue 29884571:
Issue 6945 - Add script to make filter list diffs (Closed)
Base URL: https://hg.adblockplus.org/python-abp/
Patch Set: Address comments on PS4
Created Sept. 25, 2018, 11:01 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« abp/filters/diff_script.py ('k')
|
setup.py » ('j')
|
tests/test_diff_script.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: abp/filters/renderer.py |
| =================================================================== |
| --- a/abp/filters/renderer.py |
| +++ b/abp/filters/renderer.py |
| @@ -217,6 +217,9 @@ |
| yield latest.to_string() |
| for key in set(base_metadata) - set(latest_metadata): |
| yield '! {}:'.format(base_metadata[key].key) |
| + # The removed filters are listed first because, in case a filter is both |
| + # removed and added, (and the client processes the diff in order), the |
| + # filter will be added. |
| for rule in base_rules - latest_rules: |
| yield '- {}'.format(rule) |
| for rule in latest_rules - base_rules: |
« no previous file with comments
|
« abp/filters/diff_script.py ('k')
|
setup.py » ('j')
|
tests/test_diff_script.py » ('J')
