Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .gitignore
Issue
29887585
:
Issue #5352 - generate_static_pages cannot deal with directories being turned into regular pages (Closed)
Patch Set: Addressed comments from Patch Set #4
Created Oct. 5, 2018, 11:28 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Addressed comments from Patch #1
Patch Set 3: Addressed comments from Patch Set #2
Patch Set 4: Fixed issue causing tests to fail in Patch Set #3
Patch Set 5: Addressed comments from Patch Set #4
Right:
Patch Set 1: None
Patch Set 2: Addressed comments from Patch #1
Patch Set 3: Addressed comments from Patch Set #2
Patch Set 4: Fixed issue causing tests to fail in Patch Set #3
Patch Set 5: Addressed comments from Patch Set #4
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
cms/bin/generate_static_pages.py
tests/expected_output/en/sitemap
tests/test_generation_exceptional_cases.py
tests/test_site/pages/foo/bar.md
tox.ini
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
.hgignore »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 /build/
1 /build/
2 /dist/
2 /dist/
3 /.tox/
3 /.tox/
4 /.pytest_cache/
4 /.pytest_cache/
5 /.coverage
5 /.coverage
6 *.pyc
6 *.pyc
7 *.pyo
7 *.pyo
8 htmlcov/
8 htmlcov/
9
.idea/
10
OLD
NEW
« no previous file with comments
|
« no previous file
|
.hgignore »
('j') |
no next file with comments »
Edit Message
Issue 29887585: Issue #5352 - generate_static_pages cannot deal with directories being turned into regular pages (Closed)
Created Sept. 21, 2018, 1:35 p.m. by Tudor Avram
Modified Oct. 17, 2018, 2:47 p.m.
Reviewers: Vasily Kuznetsov
Base URL:
Comments: 30
This is Rietveld