lib/filterClasses.js - Issue 29934588: Issue 7094 - Encapsulate management of subscription filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterClasses.js

Issue 29934588: Issue 7094 - Encapsulate management of subscription filters (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Reworked Created Nov. 3, 2018, 2:20 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/filterClasses.js

===================================================================

--- a/lib/filterClasses.js

+++ b/lib/filterClasses.js

@@ -83,16 +83,22 @@

* @type {string}

get type()

{

throw new Error("Please define filter type in the subclass");

/**

+ * Whether this filter is lightweight.

+ * @type {boolean}

+ */

+ lightweight: false,

+ /**

* Yields subscriptions to which the filter belongs.

* @yields {Subscription}

*subscriptions()

{

if (this._subscriptions)

{

if (this._subscriptions instanceof Set)

« no previous file with comments | « no previous file | lib/filterListener.js » ('j') | no next file with comments »