Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/all.js

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)
Left Patch Set: Created Nov. 10, 2018, 3:14 a.m.
Right Patch Set: Fixed unrelated typo Created Nov. 10, 2018, 3:32 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | test/browsers/chromium.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 12 matching lines...) Expand all
23 23
24 function getBrowserBinary(module, browser) 24 function getBrowserBinary(module, browser)
25 { 25 {
26 let spec = process.env[`${browser.toUpperCase()}_BINARY`]; 26 let spec = process.env[`${browser.toUpperCase()}_BINARY`];
27 let version = module.oldestCompatibleVersion; 27 let version = module.oldestCompatibleVersion;
28 28
29 if (spec) 29 if (spec)
30 { 30 {
31 if (spec == "installed") 31 if (spec == "installed")
32 return Promise.resolve(null); 32 return Promise.resolve(null);
33 if (spec.startswith("path:")) 33 if (spec.startsWith("path:"))
34 return Promise.resolve(spec.substr(5)); 34 return Promise.resolve(spec.substr(5));
35 if (spec.startsWith("download:")) 35 if (spec.startsWith("download:"))
36 version = spec.substr(9); 36 version = spec.substr(9);
37 } 37 }
38 38
39 return module.ensureBrowser(version); 39 return module.ensureBrowser(version);
40 } 40 }
41 41
42 for (let browser of glob.sync("./test/browsers/*.js")) 42 for (let browser of glob.sync("./test/browsers/*.js"))
43 { 43 {
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 require(modulePath); 93 require(modulePath);
94 } 94 }
95 95
96 after(function() 96 after(function()
97 { 97 {
98 if (this.driver) 98 if (this.driver)
99 return this.driver.quit(); 99 return this.driver.quit();
100 }); 100 });
101 }); 101 });
102 } 102 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld