Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/browsers/firefox.js

Issue 29941694: Noissue - Fix *_BINARY=installed after update to selenium-webdriver 4.0 (Closed)
Patch Set: Fixed unrelated typo Created Nov. 10, 2018, 3:32 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/browsers/firefox.js
===================================================================
--- a/test/browsers/firefox.js
+++ b/test/browsers/firefox.js
@@ -33,7 +33,10 @@
exports.getDriver = function(browserBinary, devenvPath)
{
- let options = new firefox.Options().setBinary(browserBinary).headless();
+ let options = new firefox.Options().headless();
+ if (browserBinary != null)
+ options.setBinary(browserBinary);
+
let driver = new webdriver.Builder()
.forBrowser("firefox")
.setFirefoxOptions(options)
« no previous file with comments | « test/browsers/chromium.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld