Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: cms/converters.py

Issue 29947567: Issue 5333 - Ensure links in metadata and in most tags can be made relative (Closed) Base URL: https://hg.adblockplus.org/cms/
Patch Set: Address comments on PS1 Created Nov. 21, 2018, 4:29 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cms/converters.py
===================================================================
--- a/cms/converters.py
+++ b/cms/converters.py
@@ -326,9 +326,9 @@
return ''.join((pre, jinja2.Markup.escape(url), post))
- text = re.sub(r'(<a\s[^<>]*\b(href)=\")([^<>\"]+)(\")',
+ text = re.sub(r'(<[\w]+\s[^<>]*\b(href)=\")([^<>\"]+)(\")',
process_link, text)
- text = re.sub(r'(<img\s[^<>]*\b(src)=\")([^<>\"]+)(\")',
+ text = re.sub(r'(<[\w]+\s[^<>]*\b(src)=\")([^<>\"]+)(\")',
process_link, text)
return text
« no previous file with comments | « no previous file | tests/expected_output/relative/de/rel_path » ('j') | tests/expected_output/relative/de/rel_path » ('J')

Powered by Google App Engine
This is Rietveld