tox.ini - Issue 29968569: Issue 4014 - Publish python-abp on PyPI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: tox.ini

Issue 29968569: Issue 4014 - Publish python-abp on PyPI (Closed) Base URL: https://hg.adblockplus.org/python-abp/

Left Patch Set: Address comment on PS4 Created Jan. 3, 2019, 4:41 a.m.

Right Patch Set: Address comment on PS5 Created Jan. 3, 2019, 9:32 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [tox]	1 [tox]

2 envlist = py27,py35,py36,pypy,flake8	2 envlist = py27,py35,py36,pypy,flake8

3	3

4 [flake8]	4 [flake8]

5 ignore = D107, N801, W503	5 ignore = D107, N801, W503

6	6

7 [testenv]	7 [testenv]

8 deps =	8 deps =

9 pytest-cov	9 pytest-cov

10 mock	10 mock

11 commands =	11 commands =

12 # For accurate coverage reports, we write a `pragma: no py{}` instruction	12 # For accurate coverage reports, we write a `pragma: no py{}` instruction

13 # containing the current Python version to a .coveragerc file	13 # containing the current Python version to a .coveragerc file
Sebastian Noack 2019/01/03 05:22:03 Nit: The additional trailing spaces in the comment Nit: The additional trailing spaces in the comment here seem inconsistent. (FWIW, IMO this comment is redundant anyway.) rhowell 2019/01/03 21:32:29 I'm guessing you mean the leading spaces here? Yea Show quoted text On 2019/01/03 05:22:03, Sebastian Noack wrote: > Nit: The additional trailing spaces in the comment here seem inconsistent. > (FWIW, IMO this comment is redundant anyway.) I'm guessing you mean the leading spaces here? Yeah, I can remove them for consistency. This comment may help save someone's time in the future trying to figure out why the line is here, but I don't feel too strongly about it either way. Sebastian Noack 2019/01/03 21:44:23 Sorry, I meant leading spaces of course. Show quoted text On 2019/01/03 21:32:29, rhowell wrote: > On 2019/01/03 05:22:03, Sebastian Noack wrote: > > Nit: The additional trailing spaces in the comment here seem inconsistent. > > (FWIW, IMO this comment is redundant anyway.) > > I'm guessing you mean the leading spaces here? Yeah, I can remove them for > consistency. Sorry, I meant leading spaces of course. Show quoted text > This comment may help save someone's time in the future trying to > figure out why the line is here, but I don't feel too strongly about it either > way. This comment just reiterates the code in the line below. In fact, it takes me more time to comprehend this comment than the code it describes. IMO, this is equivalent to adding a comment like "add one to the variable i" above "i += 1". But I don't care enough to keep arguing about this.
14 python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lin es = pragma: no py\{\} cover".format(sys.version_info[0]))'	14 python -c 'import sys; open(".coveragerc", "w").write("[report]\nexclude_lin es = pragma: no py\{\} cover".format(sys.version_info[0]))'

15 py.test --cov=abp --cov-report=term-missing --cov-fail-under=100 tests	15 py.test --cov=abp --cov-report=term-missing --cov-fail-under=100 tests

16	16

17 # We have to install our package in development mode so that pytest-cov can	17 # We have to install our package in development mode so that pytest-cov can

18 # find the .coverage and .coveragerc files.	18 # find the .coverage and .coveragerc files.

19 usedevelop = true	19 usedevelop = true

20	20

21 [testenv:flake8]	21 [testenv:flake8]

22 basepython = python3	22 basepython = python3

23 skip_install = true	23 skip_install = true

24 deps =	24 deps =

25 flake8	25 flake8

26 flake8-docstrings	26 flake8-docstrings

27 flake8-commas	27 flake8-commas

28 pep8-naming	28 pep8-naming

29 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo	29 hg+https://hg.adblockplus.org/codingtools#egg=flake8-eyeo&subdirectory=flake 8-eyeo

30 commands =	30 commands =

31 flake8 abp	31 flake8 abp

32 flake8 --extend-ignore=D1 tests setup.py	32 flake8 --extend-ignore=D1 tests setup.py

LEFT	RIGHT