Noissue - Update virtualenv instructions

README.rst

 python-abp
 ==========
 
 This repository contains a library for working with Adblock Plus filter lists,
 a script for rendering diffs between filter lists, and the script that is used
 for building Adblock Plus filter lists from the form in which they are authored
 into the format suitable for consumption by the adblocking software (aka
 rendering).
 
 .. contents::
@@ skipping 193 matching lines @@
 
 All public functions, classes and methods should have docstrings compliant with
 `NumPy/SciPy documentation guide <https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt>`_.
 One exception is the constructors of classes that the user is not expected to
 instantiate (such as exceptions).
 
 
 Using the library with R
 ------------------------
 
 Clone the repo to your local machine. Then create a virtualenv and install

[Vasily Kuznetsov, 2019/01/25 12:09:50]

Since we have published the module on PyPI, we now also have an option of just
`pip install -U python-abp`. This might not work so well for developers of
python-abp or for those who would like to be on the bleeding edge, but in
general we should probably start recommending it as the primary way of using the
library.

[rhowell, 2019/01/25 23:49:00]

Done.

 python-abp there::
 
     $ cd python-abp
-    $ virtualenv env
+    $ virtualenv venv
+    $ source venv/bin/activate

[Vasily Kuznetsov, 2019/01/25 12:09:50]

Since we don't need the virtualenv to be activated to use the library with R (at
least it seems like it from the README), we could instead just do `venv/bin/pip
install --upgrade .`.

[rhowell, 2019/01/25 23:49:00]

Done.

     $ pip install --upgrade .
 
 
 Then import it with ``reticulate`` in R:
 
 .. code-block:: R
 
     > library(reticulate)
     > use_virtualenv("~/python-abp/env", required=TRUE)
     > abp <- import("abp.filters.rpy")
 
 Now you can use the functions with ``abp$functionname``, e.g.
 ``abp.line2dict("@@||g.doubleclick.net/pagead/$subdocument,domain=hon30.org")``.
+
+
+When you are finished, deactivate the virtualenv and delete it::

[Vasily Kuznetsov, 2019/01/25 12:09:50]

If you agree with the suggestion above about not activating the virtualenv, we
don't really need this part. Most likely people will keep using the library and
they would want to keep the virtualenv. The also won't need to deactivate it
because it was never activated.

If you prefer the activation approach, we should probably still consider the
likely use case of using the same installation of python-abp and the same
virtualenv many times. I would say that the part about deleting it should be
more separated.

[rhowell, 2019/01/25 23:49:00]

Done.

+
+    $ deactivate
+    $ rm -r venv/