Noissue - Work around N812 and E117 from flake8 update

tests/test_render_script.py

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 12 matching lines @@
 
 import os
 import pytest
 import subprocess
 import threading
 
 try:
     import SimpleHTTPServer
     import SocketServer
 except ImportError:  # The modules were renamed/moved in Python 3.
-    import http.server as SimpleHTTPServer
-    import socketserver as SocketServer
+    from http import server
+    import socketserver
+    SimpleHTTPServer, SocketServer = server, socketserver

[rhowell, 2019/01/29 20:28:39]

Just curious, why not do it in 2 lines instead of 3?  E.g.

    from http import server as SimpleHTTPServer  # noqa: N812
    import socketserver as SocketServer  # noqa: N812

This way, we're more explicit in acknowledging the linter error, we save a line,
and it seems _slightly_ more readable to me. This method also seems consistent
with how some other popular projects handle similar situations (e.g.
https://github.com/pypa/pip/blob/master/src/pip/_internal/utils/hashes.py#L14).

[Vasily Kuznetsov, 2019/01/30 10:42:48]

I was trying to avoid disabling the linter. But all in all, my code is working
around the linter anyway, so we might as well be honest and mark it explicitly.
I'll go with your version.

 
 
 @pytest.fixture
 def rootdir(tmpdir):
     """Directory with prepared list fragments."""
     rootdir = tmpdir.join('root')
     rootdir.mkdir()
     # Simple file with just `Ok` and a non-ascii unicode character in it.
     rootdir.join('simple.txt').write('[Adblock]\nOk')
     # Fragment with a non-ascii character.
@@ skipping 157 matching lines @@
 
 @pytest.mark.slowtest
 def test_failed_web_include(rootdir, dstfile, webserver_port):
     url = 'http://localhost:{}/missing.txt'.format(webserver_port)
     webinc = rootdir.join('webinc.txt')
     webinc.write('[Adblock]\n%include {}%'.format(url))
     code, err, _ = run_script(str(webinc), str(dstfile))
     assert code == 1
     assert err.startswith(
         "HTTP 404 Not found: '{0}' when including '{0}'".format(url))