Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: ext/background.js

Issue 29997602: Issue 7256 - Stop using 19x19 and 38x38 icons (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Created Feb. 3, 2019, 8:45 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | icons/abp-19.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ext/background.js
===================================================================
--- a/ext/background.js
+++ b/ext/background.js
@@ -326,20 +326,18 @@
// Firefox for Android displays the browser action not as an icon but
// as a menu item. There is no icon, but such an option may be added
// in the future.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1331746
if (change == "iconPath" && "setIcon" in browser.browserAction)
{
let path = {
16: this._changes.iconPath.replace("$size", "16"),
- 19: this._changes.iconPath.replace("$size", "19"),
20: this._changes.iconPath.replace("$size", "20"),
32: this._changes.iconPath.replace("$size", "32"),
- 38: this._changes.iconPath.replace("$size", "38"),
40: this._changes.iconPath.replace("$size", "40")
};
try
{
return browser.browserAction.setIcon({tabId: this._tabId, path});
}
catch (e)
{
« no previous file with comments | « no previous file | icons/abp-19.png » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld