Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterClasses.js

Issue 30000586: Issue 7265 - Orgnanize request blocking filters by domain (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Feb. 6, 2019, 3:19 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/matcher.js ('K') | « lib/matcher.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/filterClasses.js
===================================================================
--- a/test/filterClasses.js
+++ b/test/filterClasses.js
@@ -625,20 +625,21 @@
{
let filter1 = Filter.fromText("foo$domain=blocking.example.com");
let filter2 = Filter.fromText("bar$domain=blocking.example.com");
let filter3 = Filter.fromText("elemhide.example.com##.foo");
let filter4 = Filter.fromText("elemhide.example.com##.bar");
// This compares the references to make sure that both refer to the same
// object (#6815).
+
+ // For both request blocking and element hiding filters, the value of the
+ // property is cached internally only on second access.
+ test.notEqual(filter1.domains, filter2.domains);
test.equal(filter1.domains, filter2.domains);
-
- // For element hiding filters, the value of the property is cached internally
- // only on second access.
test.notEqual(filter3.domains, filter4.domains);
test.equal(filter3.domains, filter4.domains);
let filter5 = Filter.fromText("bar$domain=www.example.com");
let filter6 = Filter.fromText("www.example.com##.bar");
test.notEqual(filter2.domains, filter5.domains);
« lib/matcher.js ('K') | « lib/matcher.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld