Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/browser/snippets.js

Issue 30024560: Issue 7450 - Implement hide-if-contains-visible-text snippet (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Added some more CSS properties to check. Minor review comments addressed. Created April 27, 2019, 5:31 p.m.
Right Patch Set: Updated patch for real Created May 9, 2019, 12:04 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/content/snippets.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 element = document.getElementById("article"); 343 element = document.getElementById("article");
344 expectVisible(test, element, "article"); 344 expectVisible(test, element, "article");
345 element = document.getElementById("article2"); 345 element = document.getElementById("article2");
346 expectVisible(test, element, "article2"); 346 expectVisible(test, element, "article2");
347 347
348 await runSnippet( 348 await runSnippet(
349 test, "hide-if-contains-visible-text", "Spon", "#parent > article", "#parent > article a" 349 test, "hide-if-contains-visible-text", "Spon", "#parent > article", "#parent > article a"
350 ); 350 );
351 351
352 element = document.getElementById("article"); 352 element = document.getElementById("article");
353 expectHidden(test, element, "article"); 353 expectVisible(test, element, "article");
hub 2019/04/29 18:24:26 Actually this should be `expectVisible` since the
hub 2019/04/30 16:08:33 This is now fixed in current patch.
354 element = document.getElementById("article2"); 354 element = document.getElementById("article2");
355 expectHidden(test, element, "article2"); 355 expectHidden(test, element, "article2");
356 element = document.getElementById("article3"); 356 element = document.getElementById("article3");
357 expectVisible(test, element, "article3"); 357 expectVisible(test, element, "article3");
358 358
359 test.done(); 359 test.done();
360 }; 360 };
LEFTRIGHT

Powered by Google App Engine
This is Rietveld