Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/FilterEngine.h

Issue 4578638519336960: Issue 1296 - Add SetUpdateAvailableCallback (Closed)
Left Patch Set: Created Sept. 18, 2014, 3:12 p.m.
Right Patch Set: Fix typo, only invoke callback when the updater passes a URL Created Sept. 19, 2014, 2:51 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/FilterEngine.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 305
306 /** 306 /**
307 * Forces an immediate update check. 307 * Forces an immediate update check.
308 * `FilterEngine` will automatically check for updates in regular intervals, 308 * `FilterEngine` will automatically check for updates in regular intervals,
309 * so applications should only call this when the user triggers an update 309 * so applications should only call this when the user triggers an update
310 * check manually. 310 * check manually.
311 * @param callback Optional callback to invoke when the update check is 311 * @param callback Optional callback to invoke when the update check is
312 * finished. The string parameter will be empty when the update check 312 * finished. The string parameter will be empty when the update check
313 * succeeded, or contain an error message if it failed. 313 * succeeded, or contain an error message if it failed.
314 * Note that the callback will be invoked whether updates are 314 * Note that the callback will be invoked whether updates are
315 * availble or not - to react to updates being available, use 315 * available or not - to react to updates being available, use
Wladimir Palant 2014/09/18 19:44:17 Nit: available
Felix Dahlke 2014/09/19 02:51:41 Done.
316 * `FilterEngine::SetUpdateAvailableCallback()`. 316 * `FilterEngine::SetUpdateAvailableCallback()`.
317 */ 317 */
318 void ForceUpdateCheck(UpdateCheckDoneCallback callback = 0); 318 void ForceUpdateCheck(UpdateCheckDoneCallback callback = 0);
319 319
320 /** 320 /**
321 * Sets the callback invoked when the filters change. 321 * Sets the callback invoked when the filters change.
322 * @param callback Callback to invoke. 322 * @param callback Callback to invoke.
323 */ 323 */
324 void SetFilterChangeCallback(FilterChangeCallback callback); 324 void SetFilterChangeCallback(FilterChangeCallback callback);
325 325
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
368 ContentType contentType, 368 ContentType contentType,
369 const std::string& documentUrl) const; 369 const std::string& documentUrl) const;
370 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params); 370 void UpdateAvailable(UpdateAvailableCallback callback, JsValueList& params);
371 void UpdateCheckDone(const std::string& eventName, 371 void UpdateCheckDone(const std::string& eventName,
372 UpdateCheckDoneCallback callback, JsValueList& params); 372 UpdateCheckDoneCallback callback, JsValueList& params);
373 void FilterChanged(FilterChangeCallback callback, JsValueList& params); 373 void FilterChanged(FilterChangeCallback callback, JsValueList& params);
374 }; 374 };
375 } 375 }
376 376
377 #endif 377 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld