Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: sitescripts/filterhits/web/submit.py

Issue 4615801646612480: Issue 395 - Filter hits statistics backend (Closed)
Patch Set: Make test log directory path configurable and ensure it's always cleared. Created March 30, 2015, 3:12 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # coding: utf-8
2
3 # This file is part of the Adblock Plus web scripts,
4 # Copyright (C) 2006-2015 Eyeo GmbH
5 #
6 # Adblock Plus is free software: you can redistribute it and/or modify
7 # it under the terms of the GNU General Public License version 3 as
8 # published by the Free Software Foundation.
9 #
10 # Adblock Plus is distributed in the hope that it will be useful,
11 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # GNU General Public License for more details.
14 #
15 # You should have received a copy of the GNU General Public License
16 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17
18 import json
19 import MySQLdb
20 import tempfile
21 import time
22 import traceback
23 import os
24 from datetime import datetime
25 from errno import EEXIST
26
27 from sitescripts.web import url_handler
28 from sitescripts.utils import get_config, setupStderr
29 from sitescripts.filterhits import db, geometrical_mean
30 from sitescripts.filterhits.web import common
31
32 def log_filterhits(data, basepath, query_string):
33 """
34 This logs the provided filterhits data as JSON to a file named after
35 the current timestamp in a directory named after the current date.
36 """
37 now = time.gmtime()
38
39 dir_name = time.strftime("%Y-%m-%d", now)
40 path = os.path.join(basepath, dir_name)
41 try:
42 os.makedirs(path)
43 except OSError as e:
44 if e.errno != EEXIST:
45 raise
46
47 with tempfile.NamedTemporaryFile(
48 prefix = str(int(time.mktime(now))) + "-",
49 suffix = ".log",
50 dir = path,
51 delete = False
52 ) as f:
53 print >> f, "[%s] %s" % (time.strftime('%d/%b/%Y:%H:%M:%S', now), query_stri ng)
54 json.dump(data, f)
55 return f.name
56
57 @url_handler("/submit")
58 def submit(environ, start_response):
59 setupStderr(environ["wsgi.errors"])
60 config = get_config()
61
62 # Check that this is a POST request
63 if environ["REQUEST_METHOD"] != "POST":
64 return common.show_error("Unsupported request method", start_response)
65
66 # Parse the submitted JSON
67 try:
68 data = json.loads(environ["wsgi.input"].read(int(environ["CONTENT_LENGTH"])) )
69 except (KeyError, IOError, ValueError):
70 return common.show_error("Error while parsing JSON data.", start_response)
71
72 # Make sure the submitted data was contained within an object at least
73 if not isinstance(data, dict):
74 return common.show_error("Error, data must be contained within an object.", start_response)
75
76 # Log the data to a file
77 log_dir = config.get("filterhitstats", "log_dir")
78 try:
79 log_file = log_filterhits(data, log_dir, environ.get("QUERY_STRING", ""))
80 except (OSError, IOError):
81 traceback.print_exc()
82 return common.show_error("Failed to write data to log file!", start_response ,
83 "500 Logging error")
84
85 # Update the geometrical_mean aggregations in the database
86 interval = config.get("filterhitstats", "interval")
87 try:
88 db_connection = db.connect()
89 try:
90 db.write(db_connection, geometrical_mean.update(interval, data))
91 finally:
92 db_connection.close()
93 except:
94 # Updating the aggregations in the database failed for whatever reason,
95 # log the details but continue to return 200 OK to the client to avoid
96 # re-transmission of the data.
97 processing_error_log = os.path.join(config.get("filterhitstats", "log_dir"),
98 "processing-errors.log")
99 with open(processing_error_log, "a+") as f:
100 message = "Problem processing data file %s:\n%s" % (
101 log_file, traceback.format_exc()
102 )
103 print >> f, "[%s] %s" % (datetime.now().strftime('%d/%b/%Y:%H:%M:%S %z'), message)
104
105 # Send back a 200 OK response
106 response_headers = [("Content-type", "text/plain")]
107 start_response("200 OK", response_headers)
108 return []
OLDNEW
« sitescripts/filterhits/test/test_helpers.py ('K') | « sitescripts/filterhits/web/query.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld