Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/filterhits/web/submit.py

Issue 4615801646612480: Issue 395 - Filter hits statistics backend (Closed)
Patch Set: Simplified geometrical_mean code and reduced filter inserts. Created March 16, 2015, 4:24 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sitescripts/filterhits/web/submit.py
diff --git a/sitescripts/filterhits/web/submit.py b/sitescripts/filterhits/web/submit.py
new file mode 100644
index 0000000000000000000000000000000000000000..c79d7687365a9cddea1238c588b5a090296e1388
--- /dev/null
+++ b/sitescripts/filterhits/web/submit.py
@@ -0,0 +1,78 @@
+# coding: utf-8
+
+# This file is part of the Adblock Plus web scripts,
+# Copyright (C) 2006-2015 Eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
+
+import MySQLdb, json, os
+from datetime import datetime
+from sitescripts.web import url_handler
+from sitescripts.utils import get_config, setupStderr
+from sitescripts.filterhits import common, db, geometrical_mean
+
+@url_handler("/submit")
+def submit(environ, start_response):
+ setupStderr(environ["wsgi.errors"])
+ config = get_config()
+
+ # Check that this is a POST request
+ if environ["REQUEST_METHOD"] != "POST":
+ return common.show_error("Unsupported request method", start_response)
+
+ # Parse the submitted JSON
+ try:
+ data = json.loads(environ["wsgi.input"].read(int(environ["CONTENT_LENGTH"])))
+ except (KeyError, IOError, ValueError):
+ return common.show_error("Error while parsing JSON data.", start_response)
+
+ # Make sure the submitted data was contained within an object at least
+ if not isinstance(data, dict):
+ return common.show_error("Error, data must be contained within an object.", start_response)
+
+ # Log the data to a file
+ if not db.testing:
+ log_dir = config.get("filterhitstats", "log_dir")
+ try:
+ log_file = common.log_filterhits(data, log_dir,
+ environ.get("QUERY_STRING", ""))
+ except (OSError, IOError):
+ return common.show_error("Failed to write data to log file!", start_response,
+ "500 Logging error")
+
+ # Update the geometrical_mean aggregations in the database
+ interval = config.get("filterhitstats", "interval")
+ try:
+ db_connection = db.connect()
+ try:
+ db.write(db_connection, geometrical_mean.update(interval, data))
+ finally:
+ db_connection.close()
+ except (KeyError, MySQLdb.Error), e:
+ # Updating the aggregations in the database failed for whatever reason,
+ # log the details but continue to return 200 OK to the client to avoid
+ # re-transmission of the data.
+ if not db.testing:
+ processing_error_log = os.path.join(config.get("filterhitstats", "log_dir"),
+ "processing-errors.log")
+ with open(processing_error_log, "a+") as f:
+ if isinstance(e, KeyError):
+ message = "KeyError (%s) when processing data file %s\n" % (str(e.args[0]), log_file)
+ elif isinstance(e, MySQLdb.Error):
+ message = "MySQL error (%d) when processing data file %s: \"%s\"\n" % (e.args[0], log_file, e.args[1])
+ f.write("[%s] %s" % (datetime.now().strftime('%d/%b/%Y:%H:%M:%S %z'), message))
+
+ # Send back a 200 OK response
+ response_headers = [("Content-type", "text/plain")]
+ start_response("200 OK", response_headers)
+ return []
« sitescripts/filterhits/geometrical_mean.py ('K') | « sitescripts/filterhits/web/query.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld