Issue 2120 - Add support for animations.

filters/inline_image.py

+# This file is part of the Adblock Plus website,
+# Copyright (C) 2006-2015 Eyeo GmbH
+#
+# Adblock Plus is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3 as
+# published by the Free Software Foundation.
+#
+# Adblock Plus is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+
+import mimetypes
+import urllib
+
+def inline_image(path):

[Sebastian Noack, 2015/04/10 07:55:46]

The code here isn't specific to images. So you might rather want to call it
"path_to_data_url" or "inline_data" or something like that.

+  mime_type = mimetypes.guess_type(path)[0]

[Sebastian Noack, 2015/04/10 07:55:46]

Note that mimetype.guess_type() might return None.

[kzar, 2015/04/11 13:32:01]

You're right, if we make this filter generic for all files perhaps it does
matter. I now accept mime_type as an argument, if not specified try to guess it,
if that fails default to "application/octet-stream".

+  with open(path, "rb") as f:

[Sebastian Noack, 2015/04/10 07:55:46]

Do we really want to resolve the path relative to the CWD?

Also we probably should normalize path separators. Otherwise it won't work on
Windows when using posix path seperators in the template and vice-versa.

[kzar, 2015/04/11 13:32:01]

Good point, I now make use of the cms.Source methods instead.

+    encoded = urllib.quote(f.read().encode("base64"))

[Sebastian Noack, 2015/04/10 09:50:25]

I'm not a fan of Python's str-to-str encodings. Calling .encode() on str or
having .decode() return str is kinda unexpected. Moreover, does the base-64
encoding always append an unneeded newline. So I'd prefer to use the base64
module instead.

output = StringIO()
output.write("data:%s;base64," % mime_type)
base64.encode(f, output)
return output.getvalue()

[kzar, 2015/04/11 13:32:01]

I'm not sure this is possible now that I'm using the read_file method of
cms.Source.

[kzar, 2015/04/11 14:05:21]

Done.

+  return "data:%s;base64,%s" % (mime_type, encoded)