Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: manifests/filtermasterserver.pp
Issue
4810150141493248
:
Issue 122 - Puppet ENC via Hiera (Closed)
Patch Set: 112 - Puppet ENC via Hiera
Created Oct. 8, 2014, 3:02 a.m.
Left:
Base
Patch Set 1: None
Patch Set 2: 112 - Puppet ENC via Hiera
Patch Set 3: 112 - Puppet ENC via Hiera
Patch Set 4: 112 - Integrate run.py and monitoring with Hiera
Patch Set 5: 112 - Integrate run.py and monitoring with Hiera
Patch Set 6: Puppet ENC via Hiera
Patch Set 7: Puppet ENC via Hiera
Patch Set 8: Puppet ENC via Hiera
Patch Set 9: Puppet ENC via Hiera - Without Arrow Alignment
Right:
Patch Set 1: None
Patch Set 2: 112 - Puppet ENC via Hiera
Patch Set 3: 112 - Puppet ENC via Hiera
Patch Set 4: 112 - Integrate run.py and monitoring with Hiera
Patch Set 5: 112 - Integrate run.py and monitoring with Hiera
Patch Set 6: Puppet ENC via Hiera
Patch Set 7: Puppet ENC via Hiera
Patch Set 8: Puppet ENC via Hiera
Patch Set 9: Puppet ENC via Hiera - Without Arrow Alignment
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.hgignore
README.md
Vagrantfile
hiera/development/base.yaml
hiera/development/hosts.yaml
hiera/hiera.yaml
hiera/install-precise.py
hiera/puppet-node-classifier.rb
hiera/roles/codereviewserver.yaml
hiera/roles/intraforumserver.yaml
manifests/codereviewserver.pp
manifests/downloadserver.pp
manifests/filtermasterserver.pp
manifests/filterserver.pp
manifests/intraforumserver.pp
manifests/issuesserver.pp
manifests/monitoringserver.pp
manifests/nodes.pp
manifests/statsserver.pp
manifests/updateserver.pp
manifests/webserver.pp
modules/base/manifests/init.pp
modules/filtermaster/manifests/init.pp
modules/statsclient/manifests/init.pp
modules/statsmaster/manifests/init.pp
View unified diff
|
Download patch
« hiera/puppet-node-classifier.rb
('K') |
« manifests/downloadserver.pp
('k') |
manifests/filterserver.pp »
('j') |
modules/base/manifests/init.pp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 node 'filtermaster1' {
1 node 'filtermaster1' {
2
include
base,
filtermaster
2
include filtermaster
3
3
4
class {'nagios::client':
5
server_address => 'monitoring.adblockplus.org'
6
}
7 }
4 }
OLD
NEW
« hiera/puppet-node-classifier.rb
('K') |
« manifests/downloadserver.pp
('k') |
manifests/filterserver.pp »
('j') |
modules/base/manifests/init.pp »
('J')
Edit Message
Issue 4810150141493248: Issue 122 - Puppet ENC via Hiera (Closed)
Created Sept. 8, 2014, 11:56 a.m. by mathias
Modified March 17, 2015, 4:28 a.m.
Reviewers: Felix Dahlke, Wladimir Palant
Base URL:
Comments: 143
This is Rietveld