Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: modules/downloadserver/files/site.conf

Issue 4851712741343232: Issue 1451 - Redirect Android devbuild update requests for versions that crash when detecting an up… (Closed)
Patch Set: Check $arg_addonVersion Created Sept. 29, 2014, 11:48 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 keepalive_timeout 0; 1 keepalive_timeout 0;
2 root /var/www/downloads; 2 root /var/www/downloads;
3 3
4 location /.hg 4 location /.hg
5 { 5 {
6 internal; 6 internal;
7 } 7 }
8 8
9 # This redirect is necessary since we accidentally set the wrong 9 # This redirect is necessary since we accidentally set the wrong
10 # update URL in ABP for Android 1.2. It can be removed once we're 10 # update URL in ABP for Android 1.2. It can be removed once we're
11 # not seeing anyone requesting this file anymore. 11 # not seeing anyone requesting this file anymore.
12 # Note that this intentionally promotes devbuilds to release builds. 12 # Note that this intentionally promotes devbuilds to release builds.
13 # Since newer versions should use the new devbuild and release 13 # Since newer versions should use the new devbuild and release
14 # build update URLs requested by libadblockplus, leaving this 14 # build update URLs requested by libadblockplus, leaving this
15 # redirect around won't really hurt. 15 # redirect around won't really hurt.
16 location /devbuilds/adblockplusandroid/updates.xml 16 location /devbuilds/adblockplusandroid/updates.xml
17 { 17 {
18 rewrite ^ https://adblockplus.org/androidupdates.xml?$query_string redirect; 18 rewrite ^ https://adblockplus.org/androidupdates.xml?$query_string redirect;
19 } 19 }
20 20
21 location /devbuilds 21 location /devbuilds
22 { 22 {
23 # This is necessary since ABP for Android revisions 323 to 337 crash when
24 # detecting an update. Fortunately, we repeated the revision in addonVersion
25 # in these versions for some reason, so we can use that pattern to detect
26 # them.
27 if ($arg_addonVersion ~ "^1\.2\.1\.3\d\d\.3\d\d$")
28 {
29 return 200 '{}';
30 }
23 alias /var/www/devbuilds; 31 alias /var/www/devbuilds;
24 } 32 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld