Issue 1681 - Incorrect usage of BString

src/plugin/PluginClass.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginClass.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
 #include "PluginMimeFilterClient.h"
 #include "PluginClient.h"
 #include "PluginClientFactory.h"
 #include "PluginMutex.h"
@@ skipping 1213 matching lines @@
     break;
   case ID_MENU_SETTINGS:
     {
       CComQIPtr<IWebBrowser2> browser = GetAsyncBrowser();
       if (browser)
       {
         VARIANT vFlags;
         vFlags.vt = VT_I4;
         vFlags.intVal = navOpenInNewTab;
 
-        BSTR urlToNavigate = BString(UserSettingsFileUrl());
+        auto userSettingsFileUrl = UserSettingsFileUrl();
+        ATL::CComBSTR urlToNavigate(userSettingsFileUrl.length(), userSettingsFileUrl.c_str());

[Eric, 2014/12/12 15:48:56]

The CComBSTR constructor takes an ordinary signed 'int' here, which can generate
a spurious warning. (Perhaps not our default build warning level, but still ...)
I'd put an explicit cast in place to make the issue go away forever.

         HRESULT hr = browser->Navigate(urlToNavigate, &vFlags, NULL, NULL, NULL);
         if (FAILED(hr))
         {
           vFlags.intVal = navOpenInNewWindow;
 
           hr = browser->Navigate(urlToNavigate, &vFlags, NULL, NULL, NULL);
           if (FAILED(hr))
           {
             DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_NAVIGATION, PLUGIN_ERROR_NAVIGATION_SETTINGS, "Navigation::Failed")
           }
@@ skipping 619 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }