Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClass.cpp

Issue 4859310991474688: Issue 1681 - Incorrect usage of BString (Closed)
Patch Set: Created Dec. 10, 2014, 11:34 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/plugin/PluginUtil.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClass.cpp
diff --git a/src/plugin/PluginClass.cpp b/src/plugin/PluginClass.cpp
index ec695ee2de3dbcf13be0979675f0e95a015dc82c..42e6bfa3141d41a12ba76bf40203a5e2e5444283 100644
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -1231,7 +1231,8 @@ void CPluginClass::DisplayPluginMenu(HMENU hMenu, int nToolbarCmdID, POINT pt, U
vFlags.vt = VT_I4;
vFlags.intVal = navOpenInNewTab;
- BSTR urlToNavigate = BString(UserSettingsFileUrl());
+ auto userSettingsFileUrl = UserSettingsFileUrl();
+ ATL::CComBSTR urlToNavigate(userSettingsFileUrl.length(), userSettingsFileUrl.c_str());
Eric 2014/12/12 15:48:56 The CComBSTR constructor takes an ordinary signed
HRESULT hr = browser->Navigate(urlToNavigate, &vFlags, NULL, NULL, NULL);
if (FAILED(hr))
{
« no previous file with comments | « no previous file | src/plugin/PluginUtil.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld