Issue 2257 - Replaced non-standard function expressions with ES6 arrow functions

chrome/content/ui/composer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 144 matching lines @@
     typeNode.setAttribute("value", Policy.typeDescr[type].toLowerCase().replace(/\_/g, "-"));
     typeNode.setAttribute("label", Policy.localizedDescr[type].toLowerCase());
 
     let typeMask = RegExpFilter.typeMap[Policy.typeDescr[type]];
     typeNode._defaultType = (typeMask & defaultTypes) != 0;
     if ((isDefaultType && typeNode._defaultType) || (!isDefaultType && item.type == type))
       typeNode.setAttribute("checked", "true");
 
     if (item.type == type)
       typeNode.setAttribute("disabled", "true");
-    typeNode.addEventListener("command", function() checkboxUpdated(this), false);
+    typeNode.addEventListener("command", () => checkboxUpdated(this), false);

[tschuster, 2015/04/13 10:12:04]

I think |this| here would be wrong. It's probably the global and not the
typeNode.

[Sebastian Noack, 2015/04/13 10:22:04]

Well spotted.

     typeGroup.appendChild(typeNode);
   }
 
   let collapseDefault = E("collapseDefault");
   collapseDefault.label = collapseDefault.getAttribute(Prefs.fastcollapse ? "label_no" : "label_yes");
   E("collapse").value = "";
   E("collapse").setAttribute("label", collapseDefault.label);
 
   let warning = E("disabledWarning");
   generateLinkText(warning);
@@ skipping 72 matching lines @@
         disabledTypes.push([typeNode._lastChange || 0, "~" + value]);
     }
     if (!forceEnabledTypes.length && disabledTypes.length < enabledTypes.length)
       options.push.apply(options, disabledTypes);
     else
       options.push.apply(options, enabledTypes);
     options.push.apply(options, forceEnabledTypes);
 
     if (options.length)
     {
-      options.sort(function(a, b) a[0] - b[0]);
-      filter += "$" + options.map(function(o) o[1]).join(",");
+      options.sort((a, b) => a[0] - b[0]);
+      filter += "$" + options.map(o => o[1]).join(",");
     }
   }
   else
   {
     let defaultTypes = RegExpFilter.prototype.contentType & ~RegExpFilter.typeMap.DOCUMENT;
     let isDefaultType = (RegExpFilter.typeMap[item.typeDescr] & defaultTypes) != 0;
     if (!isDefaultType)
       filter += "$" + item.typeDescr.toLowerCase().replace(/\_/g, "-");
   }
 
@@ skipping 133 matching lines @@
  * Selects or unselects all type checkboxes except those
  * that are disabled.
  */
 function selectAllTypes(/**Boolean*/ select)
 {
   for (let typeNode = E("typeGroup").firstChild; typeNode; typeNode = typeNode.nextSibling)
     if (typeNode.getAttribute("disabled") != "true")
       typeNode.checked = select;
   updateFilter();
 }